Refactor attributes #1263
Closed
Refactor attributes #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beauby
force-pushed
the
refactor-attributes
branch
from
80eaf7e to
5fa46fd
Compare
beauby
force-pushed
the
refactor-attributes
branch
from
f97da70 to
4c115e0
Compare
| if self.class._attributes_values[name] | ||
| instance_eval(&self.class._attributes_values[name]) | ||
| elsif respond_to?(name) # To handle legacy method-based attr overriding | ||
| warn 'Overriding attributes by defining a method on the serializer is deprecated. Please use the block syntax.' |
There was a problem hiding this comment.
can this warning have a reference to more information about this decision?
|
needs rebase |
|
@NullVoxPopuli Will rebase and improve when/if we merge #1262 (which this PR relies on). |
11 tasks
|
@beauby Is there anything in this PR that remains to be done against master? |
|
Closing as equivalent changes have been merged from other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.