[Bug] ID of a relationship not reading the overridden ID attribute on the serializer of the relationship

[dasnixon]

Version: 0.10.6 - Expect the ID of the relationship to first be read from the serializer, then the object.

There is no issue on 0.10.4

I can help whip up a PR soon, just don't have the time at this moment. Figured you could fix this pretty quick (if it's a bug).

module Api
  module V1
    class QuoteSerializer < ActiveModel::Serializer
      attributes :id, ...
      ...
      # uses friendly_id gem
      belongs_to :adventure,
        serializer: Api::V1::AdventureSerializer
      ...
    end
  end
end

module Api
  module V1
    class AdventureSerializer < ActiveModel::Serializer
      attributes :id, ...
      ...
      def id
        object.to_param
      end
      ...
    end
  end
end

From 0.10.4

From 0.10.6

Thanks!

[onomated]

@dasnixon Haven't tried this on 0.10.6, but found a bug in my serializer where I was specifying id as an attribute. I removed the id attribute definition and only keep the id method and it works fine for me in 0.10.5

[dasnixon]

Oh interesting, I'll try that and get back to you @onomated. Thanks.

[bf4]

this is because belongs_to default changed to read the id on self, which means it's not instantiating the association and, with it, the association serializer....

related:

• JSON:API relationship tests no longer show v0.10.5 regression #2211
• Implement setting for including belongs_to relationship resource iden… #2151
• Adds a configuration option belongs_to_uses_id_on_self #2140