Repository navigation
chore: modernize dependencies and migrate to typescript - #142
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe project migrates Docusaurus configuration and homepage files from JavaScript to TypeScript, replaces the ESLint setup, upgrades dependencies, adds pnpm workflows, and updates documentation links and contribution instructions. ChangesDocusaurus migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the RaidGuild Handbook site by upgrading the Docusaurus stack, moving site/config code to TypeScript, and switching the repository’s developer tooling to pnpm + modern lint/format/typecheck workflows.
Changes:
- Migrate Docusaurus config, sidebars, and the homepage to TypeScript (
docusaurus.config.ts,sidebars.ts,src/pages/index.tsx) and remove the JS/JSX counterparts. - Switch to pnpm (pinned via
packageManager) and add updated scripts for formatting, linting, typechecking, and an aggregatedpnpm check. - Refresh docs/README links and instructions to match the new structure and workflow (including fixing a broken URL in
docs/dao-operations/rips.md).
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds a TS config extending Docusaurus defaults and sets deprecation-ignore behavior. |
| src/pages/index.tsx | Replaces the old JSX homepage with a typed TSX version. |
| src/pages/index.jsx | Removes the legacy JSX homepage implementation. |
| sidebars.ts | Converts sidebars config to typed TS + ESM export. |
| README.md | Updates Docusaurus version/tooling instructions and fixes/updates documentation links. |
| pnpm-workspace.yaml | Adds pnpm workspace configuration including dependency overrides. |
| package.json | Pins pnpm + Node engine, modernizes dependencies, and adds lint/format/typecheck/check scripts. |
| eslint.config.mjs | Introduces ESLint flat config for TS + React with Prettier integration. |
| docusaurus.config.ts | Adds a typed Docusaurus 3 configuration file. |
| docusaurus.config.js | Removes the legacy JS Docusaurus 2 configuration. |
| docs/dao-operations/rips.md | Fixes a malformed external URL and updates internal doc links/anchors. |
| .gitignore | Adds .env to ignored files. |
| .eslintrc.json | Removes the legacy ESLint config in favor of flat config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
package.json (1)
40-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winEnable React Hooks linting.
eslint-plugin-reactdoes not provide the Rules of Hooks or Hooks dependency checks. Addeslint-plugin-react-hooksversion 6 or later. Then enable its recommended flat configuration ineslint.config.mjs. React 19.2 requires this plugin generation for its Hooks linting semantics.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 40 - 50, Add eslint-plugin-react-hooks version 6 or later to the development dependencies, then update the flat ESLint configuration in eslint.config.mjs to include the plugin’s recommended configuration. Ensure the Rules of Hooks and Hooks dependency checks are enabled alongside the existing React linting setup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitignore:
- Line 13: Update the environment-file ignore rule in .gitignore to match .env.*
variants such as .env.local and .env.development, while explicitly allowing the
example environment file to remain trackable.
In `@package.json`:
- Line 18: Update the package.json check script to invoke format:check, lint,
typecheck, and build through pnpm run without relying on Corepack, while
preserving their existing order and fail-fast behavior.
In `@README.md`:
- Around line 30-37: Update the README prerequisites to require Node.js 22.13 or
newer to match the pnpm@11.18.0 requirement, and retain or clarify the Corepack
prerequisite for Node.js 25 and newer where Corepack is no longer bundled.
---
Nitpick comments:
In `@package.json`:
- Around line 40-50: Add eslint-plugin-react-hooks version 6 or later to the
development dependencies, then update the flat ESLint configuration in
eslint.config.mjs to include the plugin’s recommended configuration. Ensure the
Rules of Hooks and Hooks dependency checks are enabled alongside the existing
React linting setup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1ac61e36-5025-4ad6-b294-a5de73615181
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
.eslintrc.json.gitignoreREADME.mddocs/dao-operations/rips.mddocusaurus.config.jsdocusaurus.config.tseslint.config.mjspackage.jsonpnpm-workspace.yamlsidebars.tssrc/pages/index.jsxsrc/pages/index.tsxtsconfig.json
💤 Files with no reviewable changes (3)
- src/pages/index.jsx
- .eslintrc.json
- docusaurus.config.js
This pull request modernizes and upgrades the RaidGuild Handbook repository by migrating it to Docusaurus 3, updating the codebase to TypeScript, switching to pnpm for dependency management, and refactoring configuration and scripts for improved maintainability and developer experience. It also updates documentation and dependency versions to ensure compatibility and clarity.
Migration to Docusaurus 3 and TypeScript:
docusaurus.config.jsto a strongly-typeddocusaurus.config.ts, updating settings to Docusaurus 3 conventions and improving type safety. [1] [2]sidebars.jstosidebars.tsfor TypeScript support and better type checking. [1] [2]src/pages/index.jsxtosrc/pages/index.tsx, adopting TypeScript and improving code clarity. [1] [2]Tooling and Dependency Updates:
pnpm-workspace.yamlfor workspace and dependency overrides. [1] [2].eslintrc.jsonto the neweslint.config.mjsflat config format, removing the old config. [1] [2]Documentation and Developer Experience:
README.mdto reflect Docusaurus 3, TypeScript usage, pnpm commands, and new contribution/deployment instructions for clarity and accuracy. [1] [2] [3]These changes collectively modernize the project, improve type safety, streamline developer workflows, and ensure up-to-date documentation.
Summary by CodeRabbit
New Features
Documentation
Maintenance