-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix social icons base link #384
Conversation
Thanks for opening this pull request! Make sure you have assigned an issue to this respective PR 😇 |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rahuldkjain/github-profile-readme-generator/DHvHaWcaAnjP1vZr62iLDGCshuSC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Well, I also have doubt whether this pr, solves #378 |
Does it fix #378 also? |
See https://github-profile-git-fork-puneetgopinath-patch-1-rahu-fcad96.vercel.app/ |
I checked this too and it's still broken. Check the svg source from inspect element, it should be broken. |
No, the source is https://cdn.worldvectorlogo.com/logos/microsoft-sql-server.svg |
Congrats on merging your first pull request🎉! Thanks alot for your contribution. 🙏 |
What type of PR is this? (check all applicable)
Description
Fixes #382
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.
Added to documentation?