Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix social icons base link #384

Merged
merged 1 commit into from
May 1, 2021
Merged

Fix social icons base link #384

merged 1 commit into from
May 1, 2021

Conversation

PuneetGopinath
Copy link
Contributor

@PuneetGopinath PuneetGopinath commented Apr 26, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Enhancement
  • Documentation Update

Description

Fixes #382

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.

Added to documentation?

  • readme

@welcome
Copy link

welcome bot commented Apr 26, 2021

Thanks for opening this pull request! Make sure you have assigned an issue to this respective PR 😇

@vercel
Copy link

vercel bot commented Apr 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rahuldkjain/github-profile-readme-generator/DHvHaWcaAnjP1vZr62iLDGCshuSC
✅ Preview: https://github-profile-git-fork-puneetgopinath-patch-1-rahu-fcad96.vercel.app

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PuneetGopinath
Copy link
Contributor Author

LGTM 👍

Well, I also have doubt whether this pr, solves #378
Because when I browsed https://github-profile-git-fork-puneetgopinath-patch-1-rahu-fcad96.vercel.app/
I didn't do anything related to it, but that bug it solved?

@PuneetGopinath
Copy link
Contributor Author

Well, I also have doubt whether this pr, solves #378
Because when I browsed https://github-profile-git-fork-puneetgopinath-patch-1-rahu-fcad96.vercel.app/
I didn't do anything related to it, but that bug it solved?

Does it fix #378 also?

@ghost
Copy link

ghost commented Apr 29, 2021

Does it fix #378 also?

No. The mssql icon is broken from its source.

image

@PuneetGopinath
Copy link
Contributor Author

PuneetGopinath commented Apr 29, 2021

No. The mssql icon is broken from its source.

image

See https://github-profile-git-fork-puneetgopinath-patch-1-rahu-fcad96.vercel.app/
Your screenshot shows that you are in another url
See the below image
image

@ghost
Copy link

ghost commented Apr 29, 2021

I checked this too and it's still broken. Check the svg source from inspect element, it should be broken.

@PuneetGopinath
Copy link
Contributor Author

No, the source is https://cdn.worldvectorlogo.com/logos/microsoft-sql-server.svg
Preview: image

@ghost
Copy link

ghost commented Apr 29, 2021

I'm having this output.

image

@PuneetGopinath
Copy link
Contributor Author

PuneetGopinath commented Apr 29, 2021

Is it?
Looks like you use Microsoft edge, I will try in Microsoft edge.
If you have chrome, I think you can try in chrome.
UPDATE:
I works for me in Microsoft edge
But is very large:
image
I didn't understand what happened to you?
What about other maintainers of this repo, where are they?

@g-savitha g-savitha merged commit 6253936 into rahuldkjain:master May 1, 2021
@welcome
Copy link

welcome bot commented May 1, 2021

Congrats on merging your first pull request🎉! Thanks alot for your contribution. 🙏

@PuneetGopinath PuneetGopinath deleted the patch-1 branch May 1, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter svg error
2 participants