-
-
Notifications
You must be signed in to change notification settings - Fork 84
feat: exec commands on container #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds a container terminal feature to the UI by introducing a Terminal component and a new “Terminal” tab on the container details page. Updates port badge keys in the overview to avoid collisions. Adjusts API version metadata by updating a release_date timestamp. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant P as ContainerDetailsPage
participant Tabs as Tabs
participant Term as Terminal component
participant HookR as useContainerReady
participant HookX as useTerminal (xterm)
participant WS as useWebSocket
participant BE as Backend
participant DK as Docker Engine
U->>P: Navigate to container details
P->>Tabs: Render tabs (overview/images/logs/details/terminal)
U->>Tabs: Select "Terminal" tab
Tabs->>Term: Mount with containerId
Term->>HookR: Check container DOM ready
HookR-->>Term: Ready
Term->>HookX: initializeTerminal()
HookX-->>Term: terminalInstance
Term->>WS: sendJsonMessage({ action: 'terminal', data: { value: initCmd, terminalId } })
WS->>BE: Forward terminal init and subsequent I/O
BE->>DK: docker exec -it {containerId} /bin/bash || /bin/sh
DK-->>BE: PTY stream
BE-->>WS: Data frames
WS-->>Term: Data
Term-->>U: Interactive shell I/O
note over Term,WS: Init command sent once (guard + slight delay)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
zhravan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM
Closes #85
Summary by CodeRabbit
New Features
Bug Fixes
Chores