Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compatibility with python 3.5.x #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixed compatibility with python 3.5.x #17

wants to merge 6 commits into from

Conversation

zuenko
Copy link

@zuenko zuenko commented Apr 27, 2018

No description provided.

zuenko added 6 commits April 27, 2018 21:19
@zuenko
Update embeddings.py
4a9fd86 
Fixed - 'dict_values' object does not support indexing
@zuenko
Update sentence_model.py
142016a 
Fixed - 'dict_values' object does not support indexing
@zuenko
Update processing.py
ff7293e 
Deleted "force=True"
@zuenko
Update __init__.py
48075e1 
Fix - import error
@zuenko
Update sentence_model.py
73bdaa7
@zuenko
Update token_model.py
027421f
@tgalery
Copy link

tgalery commented Apr 30, 2018

@zuenko thanks for the patch it fixes most of the issues in the repo. I'm kind of wondering if imports should be done in a non relative way though.
that is:
from keras_text.token_model import TokenModelFactory
instead of
.token_model import TokenModelFactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuenko @tgalery