WIP Logger #270
Open
WIP Logger #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Im not sure if this is the right approach. I think there's something that can be dont about reusing the logger that was passed into rafter instead of autoloading it. I also split out the json renderer so it can be reused in other contexts as it's own dependency TODO * add a logger check in the autoloader. * allow passing in of a loggerFactory too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
@rafterjs/loggeris included by default in@rajfterjs/apiit would never be properly overridden by loggers either passed intoServeror as newloggerplugins.I think there's more that can be done about reusing the logger that was passed into rafter instead of autoloading it. I think that will mean ignoring autoloaded loggers and just reusing the passed one. I think we should also allow passing in of a
loggerFactoryintoServersince many rafter services now switched over to using aloggerFactoryinstead of alogger. Might need to explore this further.I also split out the json renderer so it can be reused in other contexts as it's own dependency