Minor fixes

raffaelespazzoli · Aug 9, 2023 · 4428f72 · 4428f72
1 parent 40f81aa
commit 4428f72
Showing 1 changed file with 25 additions and 26 deletions.
diff --git a/workshop/content/100-setup/lab_x_add_ingress_to_private_link_cluster.adoc b/workshop/content/100-setup/lab_x_add_ingress_to_private_link_cluster.adoc
@@ -258,37 +258,36 @@ value(s) you've just added.
 Press Enter to Continue
 ----
 
-. Add this value to your Route53 Domain (in the AWS Console)
-// . Open another terminal window and add this requested value to Route53
-// .. Set your variables (use your specific vars from before)
-// +
-// [source,sh]
-// ----
-// export HOSTED_ZONE_ID=Z01849073R81WOHBEDGNL
-// export DOMAIN=szrxx.sandbox2309.opentlc.com
-// ----
-
-// .. Create the TXT entry
-// +
-// [source,sh]
-// ----
-// aws route53 change-resource-record-sets --hosted-zone-id ${HOSTED_ZONE_ID} 
-// ----
-// +
-// .Sample Output
-// [source,texinfo]
-// ----
-
-// ----
+. Open another terminal window and add this requested value to Route53
+.. Set your variables (use your specific vars from before)
++
+[source,sh]
+----
+export HOSTED_ZONE_ID=Z01849073R81WOHBEDGNL
+export DOMAIN=szrxx.sandbox2309.opentlc.com
+----
 
+.. Create the TXT entry
++
+[source,sh]
+----
+aws route53 change-resource-record-sets --hosted-zone-id ${HOSTED_ZONE_ID} 
+----
++
+.Sample Output
+[source,texinfo]
+----
+
+----
 
 . Create TLS secret for custom domain:
 +
 [source,sh]
 ----
-CERTS=/tmp/scratch/config/live/$DOMAIN
+CERTS=$SCRATCH_DIR/config/live/$DOMAIN
+
 oc new-project my-custom-route
-oc create secret tls acme-tls --cert=$CERTS/fullchain.pem --key=$CERTS/privkey.pem
+oc create secret tls acme-tls --cert=${CERTS}/fullchain.pem --key=${CERTS}/privkey.pem
 ----
 
 . Create Custom Domain resource:
@@ -301,7 +300,7 @@ kind: CustomDomain
 metadata:
   name: acme
 spec:
-  domain: $DOMAIN
+  domain: ${DOMAIN}
   certificate:
     name: acme-tls
     namespace: my-custom-route
@@ -320,7 +319,7 @@ watch oc get customdomains
 [source,sh]
 ----
 CDO_NAME=acme
-CLB_NAME=$(oc get svc -n openshift-ingress -o jsonpath='{range .items[?(@.metadata.labels.ingresscontroller\.operator\.openshift\.io\/owning-ingresscontroller=="'$CDO_NAME'")]}{.status.loadBalancer.ingress[].hostname}{"\n"}{end}')
+CLB_NAME=$(oc get svc -n openshift-ingress -o jsonpath='{range .items[?(@.metadata.labels.ingresscontroller\.operator\.openshift\.io\/owning-ingresscontroller=="'${CDO_NAME}'")]}{.status.loadBalancer.ingress[].hostname}{"\n"}{end}')
 
 echo $CLB_NAME
 ----