Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selectors #21

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Improve selectors #21

merged 4 commits into from
Dec 4, 2019

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Dec 4, 2019

Test and improve selector behaviour, including adding tolerances to At selectors. The default eps based tolerance of rtol fixes missed matches due to floating point errors in LinRange.

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #21 into master will increase coverage by 5.79%.
The diff coverage is 77.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   69.37%   75.16%   +5.79%     
==========================================
  Files          11       11              
  Lines         431      447      +16     
==========================================
+ Hits          299      336      +37     
+ Misses        132      111      -21
Impacted Files Coverage Δ
src/DimensionalData.jl 100% <ø> (ø) ⬆️
src/array.jl 65.11% <0%> (+10.76%) ⬆️
src/primitives.jl 78.66% <75%> (+6.55%) ⬆️
src/grid.jl 80.35% <78.94%> (+19.57%) ⬆️
src/selector.jl 80.7% <80.95%> (-1.91%) ⬇️
src/interface.jl 46.66% <0%> (-6.67%) ⬇️
src/dimension.jl 79.03% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fbd42...9b99701. Read the comment docs.

@rafaqz rafaqz merged commit 8c5ce2a into master Dec 4, 2019
@rafaqz rafaqz deleted the improve_selectors branch January 17, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants