Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid #20

Merged
merged 10 commits into from
Nov 28, 2019
Merged

Grid #20

merged 10 commits into from
Nov 28, 2019

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Nov 28, 2019

Handle different kinds of grids, updating cell size and traits to match methods used on the grid. Return more accurate bounds.

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #20 into master will increase coverage by 0.37%.
The diff coverage is 35.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   60.49%   60.86%   +0.37%     
==========================================
  Files          10       11       +1     
  Lines         367      414      +47     
==========================================
+ Hits          222      252      +30     
- Misses        145      162      +17
Impacted Files Coverage Δ
src/methods.jl 80.43% <ø> (ø) ⬆️
src/DimensionalData.jl 100% <ø> (ø) ⬆️
src/metadata.jl 0% <0%> (ø)
src/array.jl 44.44% <100%> (+1.26%) ⬆️
src/selector.jl 81.25% <100%> (+0.81%) ⬆️
src/grid.jl 39.21% <28%> (+6.71%) ⬆️
src/primitives.jl 65.11% <33.33%> (-6.19%) ⬇️
src/dimension.jl 68.25% <38.88%> (+10.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e0878...86b9583. Read the comment docs.

@rafaqz rafaqz merged commit dc6bdbd into master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants