Specialize Base.sizeof() for AbstractDimArray#1196
Open
JamesWrigley wants to merge 1 commit into
Open
Conversation
Previously `sizeof(::DimArray)` would report the size of the `DimArray` struct rather than the underlying array. Reporting the size of the array is consistent with `Array`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
=======================================
Coverage 86.98% 86.99%
=======================================
Files 61 61
Lines 5849 5850 +1
=======================================
+ Hits 5088 5089 +1
Misses 761 761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Nightly failure is JuliaPy/CondaPkg.jl#205. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
sizeof(::DimArray)would report the size of theDimArraystruct rather than the underlying array. Reporting the size of the array is consistent withArray.