Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make expand_dimensions definitions non ambiguous (#795)
* Make expand_dimensions definitions non ambiguous * Update README.md formatting * Fix vertexgrid conversions in DimensionalData * Fix all issues by using conversion trait only in 2d plots since that's what we'd do anyway * Use a more intelligent method to check the axis type * Get tests going * Add comments + regular sampling check function * Drop Makie v0.19 compat, bump patch version * Drop Makie v0.19 compat, add checks for regular sampling This also fixes the convert_args for vertexgrid which was using the wrong array for lookup, causing y-flipped contourf for example. * Regular and categorical sampling are both acceptable * Apply suggestions from code review Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com> * Use DD.shiftlocus for intervals to points * Treat axis and figure keyword arguments differently They're my special snowflakes ♡ヮ♡ * Handle axis + figure attributes better * remove axis kwargs from where they shouldn't be * fix wrong attr passing when axis type is known * Warn only on irregular lookup * more information about why this is bad * Define a fallback for NoConversion traits * Specific convert for spy to compute intervals It semi works but the dimensions are still wrong, probably because of Makie converts.. --------- Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com> Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com>
- Loading branch information