Maybe Breaking (?): add missing IteratorSize method for dimensions (#822

) * add missing IteratorSize method for dimensions * test generator constructor
rafaqz · Nov 1, 2024 · aa0d4b0 · aa0d4b0
1 parent 68ea50b
commit aa0d4b0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Dimensions/dimension.jl b/src/Dimensions/dimension.jl
@@ -286,6 +286,7 @@ Base.first(d::Dimension) = val(d)
 Base.first(d::Dimension{<:AbstractArray}) = first(lookup(d))
 Base.last(d::Dimension) = val(d)
 Base.last(d::Dimension{<:AbstractArray}) = last(lookup(d))
+Base.IteratorSize(d::Dimension{<:AbstractArray}) = Base.IteratorSize(parent(d))
 Base.firstindex(d::Dimension) = 1
 Base.lastindex(d::Dimension) = 1
 Base.firstindex(d::Dimension{<:AbstractArray}) = firstindex(lookup(d))

diff --git a/test/array.jl b/test/array.jl
@@ -456,6 +456,11 @@ end
     @test_throws ArgumentError fill(5.0, (X(:e), Y(8)))
 end
 
+
+@testset "generator constructor" begin
+    [(x, y) for x in X(10:10:50), y in Y(0.0:0.1:1.0)]
+end
+
 @testset "ones, zeros, trues, falses constructors" begin
     da = @inferred zeros(X(4), Y(40.0:10.0:80.0; order=ForwardOrdered()); metadata=(a=1, b=2))
     @test eltype(da) <: Float64