test set Name

rafaqz · Nov 22, 2020 · 21b57bd · 21b57bd
1 parent 12a08c4
commit 21b57bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/name.jl b/src/name.jl
@@ -1,10 +1,13 @@
 
 abstract type AbstractName end
 
-struct NoName <: AbstractName end
 struct Name{X} <: AbstractName end
+Name(name::Symbol) = Name{name}()
 
+Base.Symbol(::Name{X}) where X = X
 Base.string(::Name{X}) where X = string(X)
+
+struct NoName <: AbstractName end
+
 Base.string(::NoName) = ""
-Base.Symbol(::Name{X}) where X = X
 Base.Symbol(::NoName) = Symbol("")
diff --git a/test/set.jl b/test/set.jl
@@ -16,6 +16,8 @@ ds = DimDataset(da2, DimArray(2a2, dimz2, :test3))
 
 @testset " Array fields" begin
     @test name(set(da2, :newname)) == :newname
+    @test name(set(da2, Name(:newname))) == Name{:newname}()
+    @test name(set(da2, NoName())) == NoName()
     @test metadata(set(da2, ArrayMetadata(Dict(:testa => "test")))).val == Dict(:testa => "test")
     @test parent(set(da2, fill(9, 3, 4))) == fill(9, 3, 4)
     # A differently sized array can't be set