-
Notifications
You must be signed in to change notification settings - Fork 69
feat: add e24c product tutorial #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jack Ma <jack@radxa.com>
Signed-off-by: Jack Ma <jack@radxa.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (5)
-
i18n/en/docusaurus-plugin-content-docs/current/e/e24c/getting-started/install-os/maskrom/install-system-windows.md (69-69)
Same issue with the maxWidth style property in this image tag.
<img src="/img/e/e24c/emmc-rkdevtool-06.webp" style={{width: '100%', maxWidth: '700px'}} />
-
i18n/en/docusaurus-plugin-content-docs/current/e/e24c/getting-started/install-os/maskrom/install-system-windows.md (84-84)
Same issue with the maxWidth style property in this image tag.
<img src="/img/e/e24c/emmc-rkdevtool-07.webp" style={{width: '100%', maxWidth: '700px'}} />
- docs/e/e24c/getting-started/install-os/maskrom/rkdevtool.md (242-242) There's a numbering issue in the Linux/macOS section. Step 3 (writing the Loader) is incorrectly labeled as step 1, which breaks the sequence of steps 1-2-1-4-5. This should be corrected to maintain proper step numbering (1-2-3-4-5).
- i18n/en/docusaurus-plugin-content-docs/current/productlist.md (68-68) The release year for Radxa E24C is set to 2025, which is in the future compared to the other products in this section that show 2024. Is this intentional or should it be updated to 2024?
- docs/e/e24c/getting-started/install-os/README.md (5-5) The title '安装系统' is in Chinese, but the repository structure and paths are in English. For consistency, consider using an English title like 'Install OS' or 'System Installation' unless this documentation is specifically intended to be in Chinese.
💡 To request another review, post a new comment with "/windsurf-review".
docs/e/e24c/getting-started/install-os/maskrom/install-system-linux.md
Outdated
Show resolved
Hide resolved
@@ -652,6 +652,22 @@ sidebar_custom_props: | |||
}, | |||
], | |||
}, | |||
{ | |||
products_name: "Radxa E24C", | |||
products_photo_url: "/home/product-pictures/e54c.webp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The product photo URL for E24C is using 'e54c.webp' instead of 'e24c.webp'. This seems inconsistent with the naming pattern for other products where the image filename typically matches the product name.
...gin-content-docs/current/e/e24c/getting-started/install-os/maskrom/install-system-windows.md
Outdated
Show resolved
Hide resolved
…linux.md Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
…started/install-os/maskrom/install-system-windows.md Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
Description of changes