Add AdvSNACRouterFlag option to set the SNAC router bit #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbat2
reviewed
May 20, 2025
Comment on lines
+534
to
+535
| When set, indicates the router is a SNAC router (stub network auto | ||
| configuration, e.g., for IPv6-only stub networks). |
There was a problem hiding this comment.
I don't think there is an official RFC yet, even though the bit has been assigned (ietf-wg-snac/draft-ietf-snac-simple#54)
There was a problem hiding this comment.
So add https://www.iana.org/assignments/icmpv6-parameters/icmpv6-parameters.xhtml#icmpv6-parameters-11 and https://datatracker.ietf.org/doc/draft-ietf-6man-snac-router-ra-flag/ which can update when there is an official RFC.
|
On Mon, May 19, 2025 at 08:53:47PM -0700, Robin H. Johnson wrote:
arkku:
> +When set, indicates the router is a SNAC router (stub network auto
> +configuration, e.g., for IPv6-only stub networks).
Please link to the RFC here
I like would to see a real commit message,
not just the commit summary.
Plus "Sign off"
Groeten
Geert Stappers
--
Silence is hard to parse
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option: AdvSNACRouterFlag. When enabled, this sets RA option bit 6, a formerly reserved bit, that is seems to be now allocated to "SNAC router".
The reason for this addition is that I noticed Apple's HomeKit devices setting this flag to 1 when advertising themselves as a Thread border router. I have multiple VLANs, and I wanted to use radvd to re-advertise the route with identical options (but different router address).
In 2019 this same bit has been proposed to stand for IPv6 only, but that does not seem to have been adopted as standard. However, tcpdump still decodes the bit as "ipv6 only". These two uses aren't necessarily contradictory, since the Stub Network advertised as such is indeed IPv6 only.