Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #41 pin scipy #42

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

radlfabs
Copy link
Owner

neptune-sklearn uses the scikit-plot package that is broken by scipy==1.12.
The problem is reported in reiinakano/scikit-plot#119 and discussed in neptune-ai/neptune-sklearn#24

Pinning scipy to <1.12 prevents scikit-plot to break during Import.

neptune-sklearn uses scikit-plot package that is broken by scipy==1.12
@radlfabs radlfabs added the bug Something isn't working label Jan 23, 2024
@radlfabs radlfabs linked an issue Jan 23, 2024 that may be closed by this pull request
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
flexcv
   core.py190597%280–281, 320–321, 566
   fold_logging.py56296%136–139
   interface.py3294287%125, 128, 182, 184, 187, 190–191, 195, 320, 325, 328, 358, 422, 427, 605, 608, 618, 622, 629, 643, 646, 664, 713, 796–797, 800–801, 877, 886, 891, 896, 900–930
   merf.py1541888%169, 172, 191, 235, 246–248, 306, 384, 400–413, 417–422, 428
   metrics.py12192%72
   model_mapping.py23387%141–143
   model_postprocessing.py2191693%123, 170, 201, 227, 266, 288–293, 303–305, 405, 552, 647
   model_selection.py70297%61, 65
   models.py95496%197, 209, 219, 223
   plot.py1262183%101–102, 111–116, 175–181, 194–200, 236
   repeated.py1151587%30–32, 217–223, 258–260, 272, 285–288, 360
   results_handling.py75791%79, 254–255, 260, 264, 267, 271
   run.py30197%50
   split.py58591%103–106, 131–134, 154
   utilities.py822668%24, 157–163, 174–210
   yaml_parser.py53394%118, 205–220
TOTAL186717191% 

Tests Skipped Failures Errors Time
237 0 💤 0 ❌ 0 🔥 2m 37s ⏱️

@radlfabs radlfabs self-assigned this Jan 23, 2024
@radlfabs radlfabs merged commit 89068f4 into main Jan 23, 2024
1 check passed
@radlfabs radlfabs deleted the 41-bug-importerror-in-neptune-sklearns-dep branch January 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ImportError in neptune-sklearn's dep
1 participant