-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple sessions per process #162
Conversation
…selected session from notification
I also have a branch messing with active application / target override notifications where all affected sessions are always shown, even if the sessions are otherwise hidden. I had to reorganize how the hidden sessions are stored and filtered though, cause it seemed like a big mess to me to figure out which list a VM is supposed to be in. It's even more experimental... |
This looks great so far! 👍 |
I think so too! I've been rocking the active notifications for a week with no issues, except for the few corner cases with empty notification I just fixed, so that feature is also merged here now. |
hey @radj307 - any chance you could merge these fixes and update the latest version? I've been hunting for a way to manage app volumes - including discord chat - via hotkeys, and your tools is super lightweight, but just falling at the final hurdle with Discords' multiple processes :/ |
@Dregu @danpowpow
Pre-release: https://github.com/radj307/volume-control/releases/tag/6.7.0-rc2 |
Hmm yeah, I guess this ended up in a draft limbo when it was good enough for me, but maybe not polished enough for everyone. I have been using this build still with no big issues with the actual features, more so from using it so rarely that the notification window lag issue becomes apparent often. Hopefully that experimental fix will help with that lag and hopefully you can get a proper release out of this pr. |
thanks for the merge and build, @radj307 - it's great to have a tool which can adjust discord chat volume via hotkeys :-) |
When routing the W10 per-app audio output to a non-default device, some applications will open (inactive) sessions to multiple devices. Or some complex apps might do so on purpose. VC treats these sessions as duplicates even though they are on different outputs, which means only the first session can be adjusted, and it's usually the wrong one.
So I fixed that...
This PR:
Haven't tested this a lot, just what I have running currently, but then again there's not much to test. I also don't really know what I'm doing, so I might be doing something silly.
Some more clutter in the mixer, but not in the notification!