[fix] Update deprecated sglang ep args in docs and scripts#554
[fix] Update deprecated sglang ep args in docs and scripts#554guapisolo wants to merge 1 commit intoradixark:mainfrom
Conversation
Summary of ChangesHello @guapisolo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily addresses the deprecation of certain Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates deprecated sglang arguments (--sglang-enable-ep-moe and --sglang-enable-deepep-moe) across documentation files and example scripts. No security vulnerabilities were found. However, a critical typo was identified in one of the updated arguments in an example script. Additionally, the removal of a large section of FSDP documentation seems out of scope for this PR and should be addressed in a separate pull request for clarity.
| --rollout-num-gpus-per-engine 64 | ||
| --sglang-mem-fraction-static 0.7 | ||
| --sglang-enable-ep-moe | ||
| ----sglang-ep-size 64 |
as the title