Add routes recipes #50

sk593 · 2025-09-15T17:01:17Z

This PR adds Recipes for the Routes resource type. Since Routes need a container for the connection to work, this PR also adds a simple container Recipe

sk593 · 2025-09-15T22:45:08Z

.github/scripts/validate-common.sh

 # Define common configuration
 setup_config() {
-  resource_folders=("Security")
+  # Define specific resource types to test instead of entire folders


Updating the workflow to allow testing to be added for individual resources instead of a namespace

Compute/routes/recipes/kubernetes/bicep/kubernetes-routes.bicep

Compute/routes/recipes/kubernetes/terraform/main.tf

sk593 · 2025-09-16T18:04:46Z

Compute/routes/test/app.bicep

+  }
+}
+
+resource myContainer 'Radius.Compute/containers@2025-08-01-preview' = {


I added this application template as an example of how the routes resource can be deployed. I'm not sure that we'd want this to be a test scenario for the repo since it's more of an integration/E2E test and it'd require the Gateway CRD to be installed on the test cluster (I set up the CRDs and necessary RBAC to deploy this when manually testing to verify that it'd work)

I'm open to suggestions on if this should be included in this repo's test framework

Compute/routes/recipes/kubernetes/terraform/main.tf

zachcasper · 2025-09-30T17:33:23Z

Compute/routes/recipes/kubernetes/bicep/kubernetes-routes.bicep

+        namespace: context.runtime.kubernetes.namespace
+      }
+    ]
+    hostnames: length(hostnames) > 0 ? hostnames : ['localhost']


Rather than defaulting to localhost, I think this should be not specified if it is not provided. From the docs:

If no hostname is specified, traffic is routed based on HTTPRoute rules and filters (optional).

I noticed this was not updated in the Terraform Recipe, only Bicep.

zachcasper · 2025-09-30T17:35:09Z

Compute/routes/recipes/kubernetes/bicep/kubernetes-routes.bicep

+        backendRefs: [
+          {
+            name: '${toLower(last(split(rule.destinationContainer.resourceId, '/')))}-${rule.destinationContainer.containerName}'
+            port: 80


This needs reference rule.destinationContainer.containerPortName. We cannot assume a port number.

Discussed offline. We'll update the containerPortName variable to expect an integer so it can be passed as an accessible input variable

lakshmimsft · 2025-10-08T17:59:45Z

application is set to required in the schema.

resource-types-contrib/Compute/routes/routes.yaml

Line 193 in 554c71f

required: [environment, application, rules]

But it's not required in the recipe. Pls check if we need to update schema to align with recipe.

lakshmimsft · 2025-10-08T21:17:47Z

@zachcasper , @sk593 perhaps this was discussed already but should include gRPC as another route_kind in the yaml and update the recipe for it?

sk593 · 2025-10-21T16:55:58Z

@zachcasper , @sk593 perhaps this was discussed already but should include gRPC as another route_kind in the yaml and update the recipe for it?

I don't think this was discussed but we can add gRPC. thoughts @zachcasper ?

YohanSciubukgian · 2025-10-21T20:24:29Z

Will this support WebSocket connections, including HTTPS-to-WSS protocol switching, especially in the context of route-based promotion capabilities?

sk593 · 2025-10-28T21:46:50Z

Will this support WebSocket connections, including HTTPS-to-WSS protocol switching, especially in the context of route-based promotion capabilities?

I'm not too familiar with HTTPs-to-WSS but I believe it should. Routes support HTTP/HTTPS so the setup for a WebSocket connection would need to be defined in the Recipe. @zachcasper do you have any additional input on this?

sk593 · 2025-10-28T21:54:31Z

application is set to required in the schema.

resource-types-contrib/Compute/routes/routes.yaml

Line 193 in 554c71f

required: [environment, application, rules]

But it's not required in the recipe. Pls check if we need to update schema to align with recipe.

I don't think it needs to be required by the Recipe. But the resource should be tied to an application

zachcasper · 2025-11-17T19:04:47Z

Compute/routes/recipes/kubernetes/bicep/kubernetes-routes.bicep

+
+// Assume Gateway already exists - use a default gateway name
+// Platform engineers should configure this via recipe parameters or environment
+var gatewayName = 'default-gateway'


What gateway controllers use default-gateway such that we should assume a default? I looked at NGINX and the default name is the release name. The Cilium gateway name is cilium.

I'm afraid users will get an error that says "default-gateway gateway not found" instead of "gatewayName parameter not set".

The recipe was being tested using the Kubernetes Gateway API. We can update this to use a parameter instead of a default name

zachcasper · 2025-11-17T19:15:51Z

Compute/routes/recipes/kubernetes/terraform/main.tf

+
+  # Assume Gateway already exists - use a default gateway name
+  # Platform engineers should configure this via recipe parameters or environment
+  gateway_name = "default-gateway"


See previous comment about 'default-gateway'.

zachcasper · 2025-11-17T19:24:58Z

Compute/routes/recipes/kubernetes/terraform/main.tf

+          namespace = var.context.runtime.kubernetes.namespace
+        }
+      ]
+      hostnames = length(local.hostnames) > 0 ? local.hostnames : ["localhost"]


I previously made this comment in the Bicep recipe:

Rather than defaulting to localhost, I think this should be not specified if it is not provided. From the docs:

If no hostname is specified, traffic is routed based on HTTPRoute rules and filters (optional).

Ah, looks like this was updated in the Bicep recipe but not Terraform. Will update

zachcasper · 2025-11-17T20:27:14Z

application is set to required in the schema.

resource-types-contrib/Compute/routes/routes.yaml

Line 193 in 554c71f

required: [environment, application, rules]

But it's not required in the recipe. Pls check if we need to update schema to align with recipe.

What would it mean to require application in the Recipe since application is only within Radius? I don't quite understand what you're proposing.

zachcasper · 2025-11-17T20:30:48Z

Will this support WebSocket connections, including HTTPS-to-WSS protocol switching, especially in the context of route-based promotion capabilities?

I'm not too familiar with HTTPs-to-WSS but I believe it should. Routes support HTTP/HTTPS so the setup for a WebSocket connection would need to be defined in the Recipe. @zachcasper do you have any additional input on this?

That sounds right to me. Should be HTTP route type.

zachcasper · 2025-11-17T20:31:45Z

@zachcasper , @sk593 perhaps this was discussed already but should include gRPC as another route_kind in the yaml and update the recipe for it?

I don't think this was discussed but we can add gRPC. thoughts @zachcasper ?

gRPC can easily be added in the future. We've covered the majority of cases here.

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 force-pushed the add-routes-recipes branch 7 times, most recently from 92aa70e to de46894 Compare September 15, 2025 22:30

sk593 commented Sep 15, 2025

View reviewed changes

zachcasper reviewed Sep 15, 2025

View reviewed changes

Compute/routes/recipes/kubernetes/bicep/kubernetes-routes.bicep Outdated Show resolved Hide resolved

sk593 force-pushed the add-routes-recipes branch 3 times, most recently from 26f04ab to 801d78a Compare September 15, 2025 23:58

lakshmimsft reviewed Sep 16, 2025

View reviewed changes

Compute/routes/recipes/kubernetes/terraform/main.tf Outdated Show resolved Hide resolved

sk593 commented Sep 16, 2025

View reviewed changes

zachcasper requested changes Sep 19, 2025

View reviewed changes

Compute/routes/recipes/kubernetes/terraform/main.tf Outdated Show resolved Hide resolved

zachcasper reviewed Sep 30, 2025

View reviewed changes

sk593 marked this pull request as ready for review September 30, 2025 18:42

sk593 requested review from a team as code owners September 30, 2025 18:42

sk593 force-pushed the add-routes-recipes branch from c60f4df to 20f2eb0 Compare September 30, 2025 19:21

sk593 force-pushed the add-routes-recipes branch from 20f2eb0 to 00cacb0 Compare October 21, 2025 16:55

sk593 force-pushed the add-routes-recipes branch from 00cacb0 to ec78cda Compare October 28, 2025 21:18

zachcasper reviewed Nov 17, 2025

View reviewed changes

zachcasper requested changes Nov 17, 2025

View reviewed changes

sk593 added 7 commits November 18, 2025 16:03

add routes recipes

a5b30b0

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update app.bicep

6369139

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update app definition

fc7f7db

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update to gateway api

0eaf862

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update routes recipe

29b6882

Signed-off-by: sk593 <shruthikumar@microsoft.com>

address comments

7f8fcad

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update routes recipe

fb57293

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 force-pushed the add-routes-recipes branch from 2f5ef09 to fb57293 Compare November 19, 2025 17:32

address comments

3d87de5

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 force-pushed the add-routes-recipes branch from 648770a to 01d5129 Compare November 24, 2025 22:32

nit

59ab01d

Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 force-pushed the add-routes-recipes branch from 01d5129 to 59ab01d Compare November 24, 2025 22:35

Merge branch 'main' into add-routes-recipes

4f693aa

Add routes recipes #50

Are you sure you want to change the base?

Add routes recipes #50

Conversation

sk593 commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sk593 Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zachcasper Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lakshmimsft commented Oct 8, 2025

Uh oh!

lakshmimsft commented Oct 8, 2025

Uh oh!

sk593 commented Oct 21, 2025

Uh oh!

YohanSciubukgian commented Oct 21, 2025

Uh oh!

sk593 commented Oct 28, 2025

Uh oh!

sk593 commented Oct 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zachcasper commented Nov 17, 2025

Uh oh!

zachcasper commented Nov 17, 2025

Uh oh!

zachcasper commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sk593 commented Sep 15, 2025 •

edited

Loading

sk593 Sep 16, 2025 •

edited

Loading

zachcasper Sep 30, 2025 •

edited

Loading