-
Notifications
You must be signed in to change notification settings - Fork 112
Updating launch.json and running-controlplane-locally doc for updated DE #8932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8932 +/- ##
=======================================
Coverage 55.65% 55.65%
=======================================
Files 599 599
Lines 40750 40750
=======================================
+ Hits 22678 22681 +3
+ Misses 16353 16352 -1
+ Partials 1719 1717 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
76603ff
to
2264d41
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bicep-extensibility library was updated to require an encoded kubeConfig string in the request payload:
ExtensibilityOperationRequestExtensions.cs#L66
@ytimocin The linked file was last updated a year ago, so I'm curious why did we start running into this issue now. Could you please share more details on this?
2264d41
to
77b4566
Compare
We were using bicep-extensibility as a submodule and the version we were using was at least 2 years old. Now, we have removed the submodules and started using Extensibility as a dependency and we are pointing to a very new version. I hope that makes sense. Let me know if you have any other questions @kachawla. |
@@ -193,7 +205,6 @@ You should be able to successfully the following commands from the Radius reposi | |||
|
|||
```sh | |||
ls ../deployment-engine/src | |||
ls ../deployment-engine/submodules/bicep-extensibility/src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we removed submodules from DE. It can be linked to the other comment you had above.
Pull latest of the `radius-project/deployment-engine` project. | ||
Run submodule update to update bicep extensibility support for extensible resources: | ||
|
||
```bash | ||
git submodule update --init --recursive | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question as above - why is this not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submodules are removed. We are only using dependencies now.
.vscode/launch.json
Outdated
"RADIUSBACKENDURI": "http://localhost:9000" | ||
"RADIUSBACKENDURI": "http://localhost:9000", | ||
"KUBECONFIG": "${env:HOME}/.kube/config", | ||
"RAD_LOCAL_DEVELOPMENT": "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this env variable (RAD_LOCAL_DEVELOPMENT
) consumed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was going to be used as a way to understand if a local development was in progress or not. After our discussion with @brooke-hamilton I decided to remove these added flags. Thanks for your review!
77b4566
to
24cfd2f
Compare
Signed-off-by: ytimocin <ytimocin@microsoft.com>
24cfd2f
to
20d66ca
Compare
Makes sense. Thanks for sharing the details. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ytimocin One more question (commented on the wrong PR earlier) - should Radius documentation be updated to guide users about different options for kube config?
Description
Problem
The bicep-extensibility library was updated to require an encoded kubeConfig string in the request payload:
ExtensibilityOperationRequestExtensions.cs#L66
However, in our current recipes, we set kubeConfig to an empty string:
Search reference
This results in the extensibility provider not having the required Kubernetes config context to execute operations. We need to ensure that kubeConfig is properly set in the request after the Deployment Engine (DE) receives it from UCP.
Solution
We handle this differently depending on the runtime environment:
Production scenarios (DE running in a cluster):
Use Kubernetes in-cluster configuration via KubernetesClientConfiguration.InClusterConfig:
https://github.com/kubernetes-client/csharp/blob/master/src/KubernetesClient/KubernetesClientConfiguration.InCluster.cs#L41
Local development scenarios (DE running outside a cluster):
Implementation Notes
We introduce the following environment variables to support this logic:
Must be set to true when running the control plane locally. This flag determines whether to use local vs. in-cluster kubeconfig resolution.
Can be set to override the default kubeconfig file location (~/.kube/config).
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: