Updating error messages to be checked in bicep recipe functional tests for the new DE #8819
Conversation
…s for the new DE Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
| @@ -397,7 +397,7 @@ func Test_BicepRecipe_LanguageFailure(t *testing.T) { | |||
| // Instead of hardcoding values, we'll validate that the rest of the message is correct. | |||
| { | |||
| Code: "DeploymentFailed", | |||
| MessageContains: "At least one resource deployment operation failed. Please see the details for the specific operation that failed.", | |||
| MessageContains: "At least one resource deployment operation failed.", | |||
There was a problem hiding this comment.
The new version: "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details."
| @@ -306,7 +306,7 @@ func Test_BicepRecipe_ParameterNotDefined(t *testing.T) { | |||
| Details: []step.DeploymentErrorDetail{ | |||
| { | |||
| Code: "InvalidTemplate", | |||
| MessageContains: "Deployment template validation failed: 'The template parameters 'a, b' in the parameters file are not valid; they are not present in the original template and can therefore not be provided at deployment time. The only supported parameters for this template are ''. Please see https://aka.ms/arm-pass-parameter-values for usage details.'.", | |||
There was a problem hiding this comment.
The new version: Deployment template validation failed: 'The following parameters were supplied, but do not correspond to any parameters defined in the template: 'a, b'. The parameters defined in the template are: ''. Please see https://aka.ms/arm-pass-parameter-values for usage details.'.
There was a problem hiding this comment.
If you're going to update the messages to the current DE text, do you have a work item tracking the work?
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8819 +/- ##
==========================================
+ Coverage 59.88% 59.89% +0.01%
==========================================
Files 595 595
Lines 40480 40480
==========================================
+ Hits 24241 24247 +6
+ Misses 14410 14406 -4
+ Partials 1829 1827 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
These 3 tests are failing because the error messages that are being looked for in the logs are updated in the new dependencies of DE.
I updated these messages to cover both cases: current DE and the new DE.
I will update the error messages after we merge in the DE work.
An example of new error messages: https://msazure.visualstudio.com/One/_search?action=contents&text=%22The%20following%20parameters%20were%20supplied%22&type=code&lp=code-Project&filters=ProjectFilters%7BOne%7DRepositoryFilters%7BAzureUX-Deployments%7D&pageSize=25&result=DefaultCollection/One/AzureUX-Deployments/GBmaster//src/Core/ErrorResponses/ErrorResponseMessages.Designer.cs.
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: