Update PR Contributor Checklist #8255

kachawla · 2025-01-18T02:45:53Z

Description

The current checklist doesn't provide a clear checkbox for scenarios where individual items are not applicable. To make it explicit, adding two checkbox options on each of the items - "Yes" and "Not Applicable". Based on the PR, one of the two options should be checked.

Type of change

Fixes: #8244

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

[NA] An overview of proposed schema changes is included in a linked GitHub issue.
[NA] A design document PR is created in the design-notes repository, if new APIs are being introduced.
[NA] If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
[NA] A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
[NA] A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
[NA] A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

The current checklist doesn't provide a clear checkbox for scenarios where individual items are not applicable. To make it explicit, adding two checkbox options on each of the items - "Yes" and "Not Applicable". Based on the PR, one of the two options should be checked. Signed-off-by: Karishma Chawla <kachawla@microsoft.com>

codecov · 2025-01-18T02:59:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (9af20f3) to head (587dc45).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8255      +/-   ##
==========================================
+ Coverage   59.81%   59.83%   +0.01%     
==========================================
  Files         590      590              
  Lines       39513    39513              
==========================================
+ Hits        23636    23643       +7     
+ Misses      14116    14111       -5     
+ Partials     1761     1759       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-21T17:58:24Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	kachawla/radius
Commit ref	`48075d9`
Unique ID	func194dad149e
Image tag	pr-func194dad149e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func194dad149e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func194dad149e
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func194dad149e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func194dad149e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func194dad149e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

superbeeny

LGTM

radius-functional-tests · 2025-01-22T01:28:06Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	kachawla/radius
Commit ref	`dcecffc`
Unique ID	func578735f8d6
Image tag	pr-func578735f8d6

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func578735f8d6
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func578735f8d6
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func578735f8d6
controller test image location: ghcr.io/radius-project/dev/controller:pr-func578735f8d6
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func578735f8d6
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests · 2025-01-23T19:07:05Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	kachawla/radius
Commit ref	`587dc45`
Unique ID	func1659130524
Image tag	pr-func1659130524

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1659130524
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1659130524
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1659130524
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1659130524
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1659130524
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

kachawla requested review from a team as code owners January 18, 2025 02:45

kachawla temporarily deployed to publish-bicep January 18, 2025 02:47 — with GitHub Actions Inactive

ytimocin approved these changes Jan 18, 2025

View reviewed changes

brooke-hamilton approved these changes Jan 21, 2025

View reviewed changes

Merge branch 'main' into pr-template

48075d9

kachawla temporarily deployed to publish-bicep January 21, 2025 17:57 — with GitHub Actions Inactive

kachawla temporarily deployed to functional-tests January 21, 2025 17:57 — with GitHub Actions Inactive

superbeeny approved these changes Jan 21, 2025

View reviewed changes

Merge branch 'main' into pr-template

dcecffc

kachawla temporarily deployed to publish-bicep January 22, 2025 01:09 — with GitHub Actions Inactive

kachawla temporarily deployed to functional-tests January 22, 2025 01:27 — with GitHub Actions Inactive

Merge branch 'main' into pr-template

aa06294

kachawla temporarily deployed to publish-bicep January 22, 2025 16:21 — with GitHub Actions Inactive

Merge branch 'main' into pr-template

7f2672f

kachawla temporarily deployed to publish-bicep January 23, 2025 18:32 — with GitHub Actions Inactive

Merge branch 'main' into pr-template

587dc45

kachawla temporarily deployed to publish-bicep January 23, 2025 19:04 — with GitHub Actions Inactive

kachawla temporarily deployed to functional-tests January 23, 2025 19:06 — with GitHub Actions Inactive

kachawla merged commit 7797bb0 into radius-project:main Jan 23, 2025
29 checks passed

kachawla deleted the pr-template branch February 12, 2025 02:38

brooke-hamilton mentioned this pull request Mar 19, 2025

REQUEST: Approvership for brooke-hamilton radius-project/community#80

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update PR Contributor Checklist #8255

Update PR Contributor Checklist #8255

Uh oh!

kachawla commented Jan 18, 2025

Uh oh!

codecov bot commented Jan 18, 2025 •

edited

Loading

Uh oh!

radius-functional-tests bot commented Jan 21, 2025 •

edited

Loading

Uh oh!

superbeeny left a comment

Uh oh!

radius-functional-tests bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Update PR Contributor Checklist #8255

Update PR Contributor Checklist #8255

Uh oh!

Conversation

kachawla commented Jan 18, 2025

Description

Type of change

Contributor checklist

Uh oh!

codecov bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radius-functional-tests bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

superbeeny left a comment

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

radius-functional-tests bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 18, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 21, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 22, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 23, 2025 •

edited

Loading