Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autorest version for Radius #8042

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Update autorest version for Radius #8042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
78c44b0
updated to autorest latest version
lakshmimsft Oct 31, 2024
9eeefba
intermidiate checkin
lakshmimsft Nov 1, 2024
d5e5274
build/make generate successful
lakshmimsft Nov 7, 2024
1ac52c5
update routes
lakshmimsft Nov 7, 2024
98b82ca
updating datastoresrp
lakshmimsft Nov 8, 2024
eb2fcb8
format tsp
lakshmimsft Nov 9, 2024
2ca74b3
add corerp
lakshmimsft Nov 10, 2024
75f4fe6
generate clients for ucp, dapr
lakshmimsft Nov 10, 2024
4075161
upd client for messengerrp
lakshmimsft Nov 11, 2024
18a7d71
setting generate-fakes=false for now
lakshmimsft Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build/generate.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,27 +79,27 @@ generate-genericcliclient: generate-node-installed generate-autorest-installed
.PHONY: generate-rad-corerp-client
generate-rad-corerp-client: generate-node-installed generate-autorest-installed generate-tsp-installed generate-openapi-spec ## Generates the corerp client SDK (Autorest).
@echo "$(AUTOREST_MODULE_VERSION) is module version"
autorest pkg/corerp/api/README.md --tag=core-2023-10-01-preview
autorest pkg/corerp/api/README.md --tag=core-2023-10-01-preview && rm pkg/corerp/api/v20231001preview/go.mod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the go.mod that we are removing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're required to set values for module and module version because we set azure-arm: true in autorest configuration. This creates a go.mod file. It looks for existing go.mod in the output directory and creates it since it doesn't already exist. We can remove it post generation of file, in our usecase, since we want the generated output to be part of the existing module at the root of the project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how were we removing it before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't need to. The updated version of autorest.go client creates a single module per invocation.


.PHONY: generate-rad-datastoresrp-client
generate-rad-datastoresrp-client: generate-node-installed generate-autorest-installed generate-tsp-installed generate-openapi-spec ## Generates the datastoresrp client SDK (Autorest).
@echo "$(AUTOREST_MODULE_VERSION) is module version"
autorest pkg/datastoresrp/api/README.md --tag=datastores-2023-10-01-preview
autorest pkg/datastoresrp/api/README.md --tag=datastores-2023-10-01-preview && rm pkg/datastoresrp/api/v20231001preview/go.mod

.PHONY: generate-rad-messagingrp-client
generate-rad-messagingrp-client: generate-node-installed generate-autorest-installed generate-tsp-installed generate-openapi-spec ## Generates the messagingrp client SDK (Autorest).
@echo "$(AUTOREST_MODULE_VERSION) is module version"
autorest pkg/messagingrp/api/README.md --tag=messaging-2023-10-01-preview
autorest pkg/messagingrp/api/README.md --tag=messaging-2023-10-01-preview && rm pkg/messagingrp/api/v20231001preview/go.mod

.PHONY: generate-rad-daprrp-client
generate-rad-daprrp-client: generate-node-installed generate-autorest-installed generate-tsp-installed generate-openapi-spec ## Generates the daprrp client SDK (Autorest).
@echo "$(AUTOREST_MODULE_VERSION) is module version"
autorest pkg/daprrp/api/README.md --tag=dapr-2023-10-01-preview
autorest pkg/daprrp/api/README.md --tag=dapr-2023-10-01-preview && rm pkg/daprrp/api/v20231001preview/go.mod

.PHONY: generate-rad-ucp-client
generate-rad-ucp-client: generate-node-installed generate-autorest-installed test-ucp-spec-examples ## Generates the UCP client SDK (Autorest).
@echo "$(AUTOREST_MODULE_VERSION) is module version"
autorest pkg/ucp/api/README.md --tag=ucp-2023-10-01-preview
autorest pkg/ucp/api/README.md --tag=ucp-2023-10-01-preview && rm pkg/ucp/api/v20231001preview/go.mod

.PHONY: generate-mockgen-installed
generate-mockgen-installed:
Expand Down
4 changes: 3 additions & 1 deletion pkg/corerp/api/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@ The following configuration generates track2 go models and client.

```yaml $(tag) != ''
version: 3.*.*
use: "@autorest/go@4.0.0-preview.55"
use: "@autorest/go@4.0.0-preview.69"
module: "github.com/radius-project/radius/pkg/corerp/api/v20231001preview"
kachawla marked this conversation as resolved.
Show resolved Hide resolved
module-version: 0.0.1
file-prefix: zz_generated_
license-header: "Licensed under the Apache License, Version 2.0 . See LICENSE in the repository root for license information.\nCode generated by Microsoft (R) AutoRest Code Generator.\nChanges may cause incorrect behavior and will be lost if the code is regenerated."
kachawla marked this conversation as resolved.
Show resolved Hide resolved
azure-arm: true
generate-fakes: false
```

### Output
Expand Down
55 changes: 28 additions & 27 deletions pkg/corerp/api/v20231001preview/zz_generated_applications_client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

67 changes: 43 additions & 24 deletions pkg/corerp/api/v20231001preview/zz_generated_client_factory.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading