Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated command instructions with examples for rad_install_kubernetes.md page #7988

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

ckansara16
Copy link
Contributor

Description

Enhanced examples with different arguments for 'rad install kubernetes' command requested in #7968

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #7968

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@ckansara16 ckansara16 requested review from a team as code owners October 11, 2024 10:57
@ckansara16 ckansara16 force-pushed the issue/7968 branch 2 times, most recently from 9ecdd4b to 0b5b958 Compare October 11, 2024 11:00
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.37%. Comparing base (ef1196f) to head (2c9233e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7988      +/-   ##
==========================================
+ Coverage   60.36%   60.37%   +0.01%     
==========================================
  Files         560      560              
  Lines       29417    29425       +8     
==========================================
+ Hits        17757    17765       +8     
  Misses      10113    10113              
  Partials     1547     1547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 11, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ckansara16/radius
Commit ref 0b5b958
Unique ID func51f6f4c8bd
Image tag pr-func51f6f4c8bd
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func51f6f4c8bd
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func51f6f4c8bd
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func51f6f4c8bd
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func51f6f4c8bd
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link
Contributor

@Reshrahim Reshrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Suggested some minor tweaks

pkg/cli/cmd/install/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
pkg/cli/cmd/install/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
@ckansara16
Copy link
Contributor Author

Thanks for the contribution. Suggested some minor tweaks

@Reshrahim updated.

ckansara16 and others added 3 commits October 17, 2024 08:56
Signed-off-by: Chintan Anilkumar Kansara <chintan.kansara@infosys.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: ckansara16 <41126429+ckansara16@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: ckansara16 <41126429+ckansara16@users.noreply.github.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Oct 17, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ckansara16/radius
Commit ref 2c9233e
Unique ID func46372aae85
Image tag pr-func46372aae85
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func46372aae85
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func46372aae85
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func46372aae85
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func46372aae85
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft merged commit 1c73038 into radius-project:main Oct 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more detail to rad install kubernetes doc
4 participants