Updating dependencies in hack/bicep-types-radius folder #7984

ytimocin · 2024-10-10T16:28:51Z

Description

Updating dependencies in hack/bicep-types-radius folder

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests · 2024-10-10T16:34:24Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`2a05e1f`
Unique ID	funcb6b76987a3
Image tag	pr-funcb6b76987a3

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb6b76987a3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb6b76987a3
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb6b76987a3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb6b76987a3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

github-actions · 2024-10-10T16:39:31Z

Unit Tests

3 478 tests ±0 3 470 ✅ ±0 5m 15s ⏱️ -9s
270 suites ±0 8 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 2b146dd. ± Comparison against base commit 12d6bce.

♻️ This comment has been updated with latest results.

codecov · 2024-10-10T16:40:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.37%. Comparing base (12d6bce) to head (2b146dd).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7984   +/-   ##
=======================================
  Coverage   60.36%   60.37%           
=======================================
  Files         560      560           
  Lines       29417    29417           
=======================================
+ Hits        17759    17761    +2     
+ Misses      10112    10111    -1     
+ Partials     1546     1545    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rynowak · 2024-10-10T16:51:34Z

@sk593 aren't we submoduling this now?

sk593 · 2024-10-10T17:26:36Z

@sk593 aren't we submoduling this now?

This seems to be updates for the radius generator code. We only submodule the bicep-types package that is kept up to date with dependabot. We haven't discussed moving the generator to it's own repo yet so I opened an issue to start that: #7986

Signed-off-by: ytimocin <ytimocin@microsoft.com>

radius-functional-tests · 2024-10-10T17:32:09Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`68a3145`
Unique ID	funccd1750f8df
Image tag	pr-funccd1750f8df

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funccd1750f8df
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funccd1750f8df
controller test image location: ghcr.io/radius-project/dev/controller:pr-funccd1750f8df
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funccd1750f8df
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

rynowak · 2024-10-10T19:37:21Z

@sk593 aren't we submoduling this now?

This seems to be updates for the radius generator code. We only submodule the bicep-types package that is kept up to date with dependabot. We haven't discussed moving the generator to it's own repo yet so I opened an issue to start that: #7986

OK Great 👍

It's been a wish of mine to move the types-generator out of radius-project/radius for some time .. Not urgent but nice to dream.

radius-functional-tests · 2024-10-11T16:28:51Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`2b146dd`
Unique ID	func60a7ff14da
Image tag	pr-func60a7ff14da

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func60a7ff14da
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func60a7ff14da
controller test image location: ghcr.io/radius-project/dev/controller:pr-func60a7ff14da
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func60a7ff14da
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

ytimocin requested review from a team as code owners October 10, 2024 16:28

ytimocin temporarily deployed to functional-tests October 10, 2024 16:28 — with GitHub Actions Inactive

Updating dependencies in hack/bicep-types-radius folder

68a3145

Signed-off-by: ytimocin <ytimocin@microsoft.com>

ytimocin force-pushed the ytimocin/bicep-types/update-deps branch from 2a05e1f to 68a3145 Compare October 10, 2024 17:30

ytimocin temporarily deployed to functional-tests October 10, 2024 17:30 — with GitHub Actions Inactive

sk593 approved these changes Oct 11, 2024

View reviewed changes

kachawla approved these changes Oct 11, 2024

View reviewed changes

Merge branch 'main' into ytimocin/bicep-types/update-deps

2b146dd

kachawla temporarily deployed to functional-tests October 11, 2024 16:27 — with GitHub Actions Inactive

lakshmimsft approved these changes Oct 11, 2024

View reviewed changes

ytimocin merged commit ba9195c into main Oct 11, 2024
31 checks passed

ytimocin deleted the ytimocin/bicep-types/update-deps branch October 11, 2024 20:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating dependencies in hack/bicep-types-radius folder #7984

Updating dependencies in hack/bicep-types-radius folder #7984

ytimocin commented Oct 10, 2024

radius-functional-tests bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

rynowak commented Oct 10, 2024

sk593 commented Oct 10, 2024

radius-functional-tests bot commented Oct 10, 2024 •

edited

Loading

rynowak commented Oct 10, 2024

radius-functional-tests bot commented Oct 11, 2024 •

edited

Loading

Updating dependencies in hack/bicep-types-radius folder #7984

Updating dependencies in hack/bicep-types-radius folder #7984

Conversation

ytimocin commented Oct 10, 2024

Description

Type of change

Contributor checklist

radius-functional-tests bot commented Oct 10, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Oct 10, 2024 • edited Loading

Unit Tests

codecov bot commented Oct 10, 2024 • edited Loading

Codecov Report

rynowak commented Oct 10, 2024

sk593 commented Oct 10, 2024

radius-functional-tests bot commented Oct 10, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Oct 10, 2024

radius-functional-tests bot commented Oct 11, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 10, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 11, 2024 •

edited

Loading