Use `ubuntu-latest` instead of a hosted 4-core runner #7973

jeefy · 2024-09-30T16:52:05Z

Description

Heya! Friendly neighborhood CNCF staffer here. The ubuntu-latest runner is already a 4-core runner, so using a hosted 4-core runner is unnecessary (and actually costs money). This PR just swaps any 4-core hosted runners to use ubuntu-latest. There should be zero change or impact, functionally this is a SKU change.

Please reach out to me in the CNCF/K8s slack(s) (jeefy) or via email (jsica@linuxfoundation.org) with any questions.

Type of change

Replaces ubuntu-latest-m (which is a pay-for 4-core hosted runner) to ubuntu-latest (which is the free 4-core runner with no real spec difference)

rynowak · 2024-09-30T17:51:42Z

Thanks @jeefy - approved the workflows so we can test this out!

radius-functional-tests · 2024-09-30T17:52:16Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	jeefy/radius
Commit ref	`01bb0bf`
Unique ID	func464a9be871
Image tag	pr-func464a9be871

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func464a9be871
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func464a9be871
controller test image location: ghcr.io/radius-project/dev/controller:pr-func464a9be871
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func464a9be871
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

codecov · 2024-09-30T18:01:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.63%. Comparing base (b2eb80b) to head (58ba102).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7973   +/-   ##
=======================================
  Coverage   60.63%   60.63%           
=======================================
  Files         534      534           
  Lines       28484    28484           
=======================================
  Hits        17271    17271           
  Misses       9697     9697           
  Partials     1516     1516

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lakshmimsft · 2024-10-01T22:26:01Z

Thank you @jeefy !
But it looks like we hit a error running out of disk space with this update consistently. (Following are errors in different runs:)
https://github.com/radius-project/radius/actions/runs/11110614862/job/30941040772?pr=7973

https://github.com/radius-project/radius/actions/runs/11110614862/job/30941845181?pr=7973

We may have to stay with ubuntu-latest-m for now until we can explore possibilities like cleaning up after steps or other optimizations.
cc @rynowak

rynowak · 2024-10-02T16:31:58Z

@jeefy - any ideas? We're using kind in the test pipelines to stand up Kubernetes, and then running tests on that cluster.

radius-functional-tests · 2024-10-07T05:21:23Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	jeefy/radius
Commit ref	`b407aba`
Unique ID	func06bf3feca5
Image tag	pr-func06bf3feca5

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func06bf3feca5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func06bf3feca5
controller test image location: ghcr.io/radius-project/dev/controller:pr-func06bf3feca5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func06bf3feca5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

ytimocin · 2024-10-07T05:23:58Z

ubuntu-latest-m has 16 GB RAM. Not sure if ubuntu-latest also has that much.

That could be the reason why one of our functional tests is failing.

Signed-off-by: Jeffrey Sica <me@jeefy.dev>

jeefy · 2024-10-09T19:09:41Z

They have the same amount of RAM, but the disk space is different (free runner: 14GB, non-free... 140GB)

I'm going to update the PR to use one of our hosted runners since it has more disk.

Signed-off-by: Jeffrey Sica <me@jeefy.dev>

radius-functional-tests · 2024-10-09T20:34:24Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	jeefy/radius
Commit ref	`a14c69b`
Unique ID	func54cf832752
Image tag	pr-func54cf832752

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func54cf832752
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func54cf832752
controller test image location: ghcr.io/radius-project/dev/controller:pr-func54cf832752
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func54cf832752
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

jeefy · 2024-10-09T20:50:20Z

Don't know why the job isn't getting picked up, and I watched other jobs outside of this repo during this. I'll have to investigate further. Thanks!

jeefy requested review from a team as code owners September 30, 2024 16:52

jeefy temporarily deployed to functional-tests September 30, 2024 17:51 — with GitHub Actions Inactive

ytimocin force-pushed the actions-optimization branch from 01bb0bf to b407aba Compare October 7, 2024 05:19

ytimocin temporarily deployed to functional-tests October 7, 2024 05:20 — with GitHub Actions Inactive

use ubuntu-latest instead of hosted 4-core runner

58ba102

Signed-off-by: Jeffrey Sica <me@jeefy.dev>

ytimocin force-pushed the actions-optimization branch from b407aba to 58ba102 Compare October 8, 2024 04:19

jeefy and others added 2 commits October 9, 2024 14:14

Merge branch 'main' into actions-optimization

df4bb3c

swap from gha to equinix runner

a14c69b

Signed-off-by: Jeffrey Sica <me@jeefy.dev>

jeefy temporarily deployed to functional-tests October 9, 2024 20:33 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `ubuntu-latest` instead of a hosted 4-core runner #7973

Use `ubuntu-latest` instead of a hosted 4-core runner #7973

jeefy commented Sep 30, 2024

rynowak commented Sep 30, 2024

radius-functional-tests bot commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading

lakshmimsft commented Oct 1, 2024

rynowak commented Oct 2, 2024

radius-functional-tests bot commented Oct 7, 2024 •

edited

Loading

ytimocin commented Oct 7, 2024

jeefy commented Oct 9, 2024

radius-functional-tests bot commented Oct 9, 2024 •

edited

Loading

jeefy commented Oct 9, 2024

Use ubuntu-latest instead of a hosted 4-core runner #7973

Are you sure you want to change the base?

Use ubuntu-latest instead of a hosted 4-core runner #7973

Conversation

jeefy commented Sep 30, 2024

Description

Type of change

rynowak commented Sep 30, 2024

radius-functional-tests bot commented Sep 30, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Sep 30, 2024 • edited Loading

Codecov Report

lakshmimsft commented Oct 1, 2024

rynowak commented Oct 2, 2024

radius-functional-tests bot commented Oct 7, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin commented Oct 7, 2024

jeefy commented Oct 9, 2024

radius-functional-tests bot commented Oct 9, 2024 • edited Loading

Radius functional test overview

Test Status

jeefy commented Oct 9, 2024

Use `ubuntu-latest` instead of a hosted 4-core runner #7973

Use `ubuntu-latest` instead of a hosted 4-core runner #7973

radius-functional-tests bot commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 7, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 9, 2024 •

edited

Loading