Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the timeout of the clean-up cluster step to 1h #7938

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update the timeout of the clean-up cluster step to 1h #7938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/cleanup-cluster.sh → ...b/scripts/cleanup-long-running-cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

set -e

echo "cleaning up cluster"
echo "cleaning up long-running cluster on Azure"

# Delete all test resources in queuemessages.
if kubectl get crd queuemessages.ucp.dev >/dev/null 2>&1; then
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/long-running-azure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,9 @@ jobs:
env:
RESOURCE_GROUP: ${{ env.AZURE_TEST_RESOURCE_GROUP }}
- name: Clean up cluster
run: ./.github/scripts/cleanup-cluster.sh
if: always()
timeout-minutes: 60
run: ./.github/scripts/cleanup-long-running-cluster.sh
- name: Download Bicep
run: |
chmod +x ./bin/rad
Expand Down Expand Up @@ -512,7 +514,7 @@ jobs:
- name: Clean up cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have two cleanup cluster steps? These both seem to be part of the test job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cleans up before the tests and the other one after the tests. This is to be extra defensive. We want to have a clean start before running the tests and want to make sure we delete everything after we run the tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. PR lgtm then

if: always()
timeout-minutes: 60
run: ./.github/scripts/cleanup-cluster.sh
run: ./.github/scripts/cleanup-long-running-cluster.sh
report-failure:
name: Report test failure
needs: [build, tests]
Expand Down