Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a check to a cast to the Recipe object #7797

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Aug 9, 2024

Description

Adding a check to a cast to the Recipe object

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Signed-off-by: ytimocin <ytimocin@microsoft.com>
@ytimocin ytimocin requested review from a team as code owners August 9, 2024 22:46
recipe, ok := obj.(*radappiov1alpha3.Recipe)
if !ok {
return []reconcile.Request{}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that there's no good way to return an error here. I agree that skipping is the most reasonable thing to do.

Copy link

github-actions bot commented Aug 9, 2024

Unit Tests

3 297 tests  ±0   3 291 ✅ ±0   4m 4s ⏱️ ±0s
  263 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 90de97a. ± Comparison against base commit 83f57c2.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.04%. Comparing base (83f57c2) to head (90de97a).

Files Patch % Lines
pkg/controller/reconciler/deployment_reconciler.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7797      +/-   ##
==========================================
- Coverage   61.04%   61.04%   -0.01%     
==========================================
  Files         523      523              
  Lines       27432    27434       +2     
==========================================
  Hits        16747    16747              
- Misses       9206     9207       +1     
- Partials     1479     1480       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 9, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 90de97a
Unique ID func545f2f8d0f
Image tag pr-func545f2f8d0f
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func545f2f8d0f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func545f2f8d0f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func545f2f8d0f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func545f2f8d0f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@ytimocin ytimocin merged commit 3d96ee6 into main Aug 9, 2024
29 checks passed
@ytimocin ytimocin deleted the ytimocin/recipeCastCheck branch August 9, 2024 23:43
superbeeny pushed a commit to superbeeny/radius that referenced this pull request Aug 14, 2024
Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants