Update functional test workflow with test Bicep types #7730

sk593 · 2024-07-08T16:19:39Z

Description

Please explain the changes you've made.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

github-actions · 2024-07-08T16:46:30Z

Unit Tests

3 275 tests ±0 3 269 ✅ ±0 3m 55s ⏱️ -4s
261 suites ±0 6 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit a81d1aa. ± Comparison against base commit 46bf036.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.

github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/darwin-amd64
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/darwin-arm64
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/linux-amd64
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/linux-arm
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/linux-arm64
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/windows-amd64
github.com/radius-project/radius/pkg/cli/tools ‑ TestGetValidPlatform/windows-arm64

github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/darwin-amd64
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/darwin-arm64
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/linux-amd64
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/linux-arm
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/linux-arm64
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/windows-amd64
github.com/radius-project/radius/pkg/cli/bicep/tools ‑ TestGetValidPlatform/windows-arm64

♻️ This comment has been updated with latest results.

codecov · 2024-07-08T16:47:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.13%. Comparing base (6aeb77a) to head (a81d1aa).

Additional details and impacted files

@@                       Coverage Diff                        @@
##           feature-bicep-compiler-merge    #7730      +/-   ##
================================================================
- Coverage                         61.15%   61.13%   -0.02%     
================================================================
  Files                               520      520              
  Lines                             27202    27202              
================================================================
- Hits                              16635    16631       -4     
- Misses                             9100     9102       +2     
- Partials                           1467     1469       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/functional-test-cloud.yaml

sk593 · 2024-07-22T22:15:19Z

.github/workflows/functional-test-cloud.yaml

+          else
+            RADIUS_VERSION="${{ env.REL_VERSION }}"
+          fi
+          cat <<EOF > ./test/bicepconfig.json


We need a temporary bicepconfig.json that will read from a PR-specific tag. So we create one here that goes into the test folder so all our functional tests will use the ACR endpoints in the generated bicepconfig. This is different from the bicepconfig.json that resides in the root radius folder (that is used for dev purposes and will always pull from latest)

What will we do when we need to do this locally? Should we have a bicepconfig.json or bicepconfig.json generator script file or something similar?

There's already a bicepconfig.json in the repo so that'll be used if you're running the tests locally

hack/bicep-types-radius/generated/index.json

.github/workflows/functional-test-cloud.yaml

kachawla · 2024-07-22T23:45:27Z

.github/workflows/functional-test-cloud.yaml

+        uses: actions/upload-artifact@v4
+        with:
+          name: radius-bicep-types
+          path: ./hack/bicep-types-radius/generated


could you remind me what's we decided for this directory? Will it be removed or renamed to something less hacky sounding than hack? :)

Ideally, we'd have this in a separate repository the same way we have bicep-types-aws. I can rename it for now if that'd be better

I see, I think at least renaming will definitely help because questions around naming for this come up often. I'm fine with following up on this in a separate PR to keep this one scoped, feel free to log an issue to drive the discussion/follow up.

That makes sense, will add this issue as part of the cleanup work

.github/workflows/functional-test-noncloud.yaml

sk593 · 2024-07-23T22:12:14Z

.github/workflows/functional-test-noncloud.yaml

+
+      - name: Publish bicep types 
+        run: | 
+          ./.rad/bin/rad-bicep publish-extension ./hack/bicep-types-radius/generated/index.json --target br:${{ env.LOCAL_REGISTRY_SERVER }}:${{ env.LOCAL_REGISTRY_PORT }}/radius:${{ env.REL_VERSION == 'edge' && 'latest' || env.REL_VERSION }} --force     


not sure if this is the correct path to the radius download but if we do a rad bicep download in a previous step so we should be able to use that binary instead of downloading Bicep again

Same question about the REL_VERSION being edge as above.

ytimocin

Is this also going to be added to the long-running test workflow? If so, I believe making this a separate action would be helpful. We can have a code pair to do that if you would like.

ytimocin · 2024-07-24T18:27:06Z

.github/workflows/functional-test-cloud.yaml

@@ -348,10 +350,49 @@ jobs:
          append: true
          message: |
            :x: Test recipe publishing failed
+
+  publish-test-bicep-types:


Should this be moved inside the build job?

I kept it as a separate job so it doesn't make the build step too long and can run in parallel. I'm not opposed to moving it into the build step though if that'd be better for this workflow

ytimocin · 2024-07-24T18:28:54Z

.github/workflows/functional-test-cloud.yaml

+          else
+            RADIUS_VERSION="${{ env.REL_VERSION }}"
+          fi
+          cat <<EOF > ./test/bicepconfig.json


What will we do when we need to do this locally? Should we have a bicepconfig.json or bicepconfig.json generator script file or something similar?

ytimocin · 2024-07-24T18:30:38Z

.github/workflows/functional-test-noncloud.yaml

+
+      - name: Generate Bicep extensibility types from OpenAPI specs
+        run: |
+          make generate-bicep-types VERSION=${{ env.REL_VERSION == 'edge' && 'latest' || env.REL_VERSION }}


Will REL_VERSION ever be edge? I couldn't find any place where we set REL_VERSION to edge in this workflow.

I think this will be needed for scheduled runs. In that case, they'd be edge but we only want to tag with latest. The parse step is missing so I'll add that

ytimocin · 2024-07-24T18:31:22Z

.github/workflows/functional-test-noncloud.yaml

+
+      - name: Publish bicep types 
+        run: | 
+          ./.rad/bin/rad-bicep publish-extension ./hack/bicep-types-radius/generated/index.json --target br:${{ env.LOCAL_REGISTRY_SERVER }}:${{ env.LOCAL_REGISTRY_PORT }}/radius:${{ env.REL_VERSION == 'edge' && 'latest' || env.REL_VERSION }} --force     


Same question about the REL_VERSION being edge as above.

sk593 · 2024-07-24T20:35:22Z

Is this also going to be added to the long-running test workflow? If so, I believe making this a separate action would be helpful. We can have a code pair to do that if you would like.

The long-running test should use the latest types uploaded so there isn't a need to generate a temporary one there. There will be a bicepconfig.json that permanently lives in the repo and points to the latest tag in the ACR

sk593 · 2024-07-30T15:08:54Z

build/validate-bicep.sh

@@ -30,7 +30,7 @@ do
        exec 3>&-
    fi

-    if [[ ! $EXITCODE -eq 0 || (! -z $STDERR && ! $STDERR == $WARNING_MSG* ) ]]
+    if [[ ! $EXITCODE -eq 0 || (! -z $STDERR && ! $STDERR == $WARNING_MSG* && ! $STDERR == *"Error"* ) ]]


This was a small bug. It'd catch all the warning messages but would miss any errors that occurred after that. So this adds a check for errors

Signed-off-by: sk593 <shruthikumar@microsoft.com>

lakshmimsft · 2024-08-01T21:29:55Z

hack/bicep-types-radius/generated/applications/applications.core/2023-10-01-preview/types.json

+          "$ref": "#/154"
+        },
+        "flags": 0,
+        "description": "Environment variables containing sensitive information can be stored as secrets. The secrets are stored in Applications.Core/SecretStores resource."


existing types.json has slightly different format/casing. checking that it is expected

"envSecrets": { "Type": 158, "Flags": 0, "Description": "Environment variables containing sensitive information can be stored as secrets. The secrets are stored in Applications.Core/SecretStores resource." } }

yes, that's expected. the generated format that the compiler expects is different than the current version we use

lakshmimsft · 2024-08-02T01:24:17Z

.github/workflows/functional-test-noncloud.yaml

+
+      - name: Publish bicep types 
+        run: | 
+          ./.rad/bin/rad-bicep publish-extension ./hack/bicep-types-radius/generated/index.json --target br:${{ env.LOCAL_REGISTRY_SERVER }}:${{ env.LOCAL_REGISTRY_PORT }}/radius:${{ env.REL_VERSION == 'edge' && 'latest' || env.REL_VERSION }} --force     


should this be ./.rad/bin/bicep since we downloaded this as bicep file above ?

no, we still download the binary to rad-bicep when downloading bicep

ytimocin · 2024-08-02T17:51:42Z

.github/workflows/functional-test-noncloud.yaml

@@ -80,6 +80,8 @@ env:
  LOCAL_REGISTRY_SERVER: "localhost"
  # Local Docker registry port
  LOCAL_REGISTRY_PORT: "5000"
+  # bicep-types ACR url for uploading Radius Bicep types
+  BICEP_TYPES_REGISTRY: 'biceptypes.azurecr.io'


Shouldn't this point to the local registry?

No, this is used to pull the AWS ACR types. anonymous pull is enabled since it's a publicly readable asset so it shouldn't require any secrets

# Description _Please explain the changes you've made._ ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <shruthikumar@microsoft.com>

# Description This PR contains all the changes for the Bicep compiler merge. The branch has had smaller PRs opened for specific features that can be found below: - [x] Bicep types generator is updated to use the `bicep-types` repository as a submodule. This includes updating the types contract and adding support for resource methods (eg `listSecrets`): 43403fd . There was also a small update to how we handle flags on the `location` [property](19afe96) - [x] Update to build workflow to initialize the submodule and publish types to `biceptypes.azurecr.io` using the `bicep publish-extension` command: fed2462 - [x] Update validate bicep workflow to validate bicep files in the repository with the official Bicep compiler. This includes updating extension imports of all bicep files and adding a `bicepconfig.json` to the repository: #7702 - [x] Update functional test workflow to publish types to `biceptypes.azurecr.io`. This includes publishing the bicep types to a PR tag and adding a temporary `bicepconfig.json` to consume the PR-specific types [#7730] - [x] Update release workflow to publish types to a release-specific tag. This includes running a build in the `bicep-types-aws` repo to publish AWS types to a release tag - [x] Updates to `rad bicep download`. This command will download the official Bicep binary instead of the Radius one. The install script calls this command so the official Bicep binary will be downloaded on a Radius install: bb8da88 - [x] Updates to `rad init` to generate a default `bicepconfig.json`. This will pull the Radius and AWS types in our ACR with the current release tag: #7664 ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- # Description _Please explain the changes you've made._ ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <shruthikumar@microsoft.com>

This PR contains all the changes for the Bicep compiler merge. The branch has had smaller PRs opened for specific features that can be found below: - [x] Bicep types generator is updated to use the `bicep-types` repository as a submodule. This includes updating the types contract and adding support for resource methods (eg `listSecrets`): radius-project@43403fd . There was also a small update to how we handle flags on the `location` [property](radius-project@19afe96) - [x] Update to build workflow to initialize the submodule and publish types to `biceptypes.azurecr.io` using the `bicep publish-extension` command: radius-project@fed2462 - [x] Update validate bicep workflow to validate bicep files in the repository with the official Bicep compiler. This includes updating extension imports of all bicep files and adding a `bicepconfig.json` to the repository: radius-project#7702 - [x] Update functional test workflow to publish types to `biceptypes.azurecr.io`. This includes publishing the bicep types to a PR tag and adding a temporary `bicepconfig.json` to consume the PR-specific types [radius-project#7730] - [x] Update release workflow to publish types to a release-specific tag. This includes running a build in the `bicep-types-aws` repo to publish AWS types to a release tag - [x] Updates to `rad bicep download`. This command will download the official Bicep binary instead of the Radius one. The install script calls this command so the official Bicep binary will be downloaded on a Radius install: radius-project@bb8da88 - [x] Updates to `rad init` to generate a default `bicepconfig.json`. This will pull the Radius and AWS types in our ACR with the current release tag: radius-project#7664  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- _Please explain the changes you've made._  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <shruthikumar@microsoft.com>

# Description This PR contains all the changes for the Bicep compiler merge. The branch has had smaller PRs opened for specific features that can be found below: - [x] Bicep types generator is updated to use the `bicep-types` repository as a submodule. This includes updating the types contract and adding support for resource methods (eg `listSecrets`): radius-project@43403fd . There was also a small update to how we handle flags on the `location` [property](radius-project@19afe96) - [x] Update to build workflow to initialize the submodule and publish types to `biceptypes.azurecr.io` using the `bicep publish-extension` command: radius-project@fed2462 - [x] Update validate bicep workflow to validate bicep files in the repository with the official Bicep compiler. This includes updating extension imports of all bicep files and adding a `bicepconfig.json` to the repository: radius-project#7702 - [x] Update functional test workflow to publish types to `biceptypes.azurecr.io`. This includes publishing the bicep types to a PR tag and adding a temporary `bicepconfig.json` to consume the PR-specific types [radius-project#7730] - [x] Update release workflow to publish types to a release-specific tag. This includes running a build in the `bicep-types-aws` repo to publish AWS types to a release tag - [x] Updates to `rad bicep download`. This command will download the official Bicep binary instead of the Radius one. The install script calls this command so the official Bicep binary will be downloaded on a Radius install: radius-project@bb8da88 - [x] Updates to `rad init` to generate a default `bicepconfig.json`. This will pull the Radius and AWS types in our ACR with the current release tag: radius-project#7664 ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- # Description _Please explain the changes you've made._ ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

This PR contains all the changes for the Bicep compiler merge. The branch has had smaller PRs opened for specific features that can be found below: - [x] Bicep types generator is updated to use the `bicep-types` repository as a submodule. This includes updating the types contract and adding support for resource methods (eg `listSecrets`): radius-project@43403fd . There was also a small update to how we handle flags on the `location` [property](radius-project@19afe96) - [x] Update to build workflow to initialize the submodule and publish types to `biceptypes.azurecr.io` using the `bicep publish-extension` command: radius-project@fed2462 - [x] Update validate bicep workflow to validate bicep files in the repository with the official Bicep compiler. This includes updating extension imports of all bicep files and adding a `bicepconfig.json` to the repository: radius-project#7702 - [x] Update functional test workflow to publish types to `biceptypes.azurecr.io`. This includes publishing the bicep types to a PR tag and adding a temporary `bicepconfig.json` to consume the PR-specific types [radius-project#7730] - [x] Update release workflow to publish types to a release-specific tag. This includes running a build in the `bicep-types-aws` repo to publish AWS types to a release tag - [x] Updates to `rad bicep download`. This command will download the official Bicep binary instead of the Radius one. The install script calls this command so the official Bicep binary will be downloaded on a Radius install: radius-project@bb8da88 - [x] Updates to `rad init` to generate a default `bicepconfig.json`. This will pull the Radius and AWS types in our ACR with the current release tag: radius-project#7664  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- _Please explain the changes you've made._  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <shruthikumar@microsoft.com>

sk593 had a problem deploying to functional-tests July 8, 2024 16:19 — with GitHub Actions Failure

sk593 force-pushed the update-func-test-workflow-bicep branch 2 times, most recently from 339ebf8 to a651cd9 Compare July 22, 2024 21:29

sk593 had a problem deploying to functional-tests July 22, 2024 21:29 — with GitHub Actions Failure

sk593 force-pushed the update-func-test-workflow-bicep branch from a651cd9 to a81d1aa Compare July 22, 2024 21:47

sk593 had a problem deploying to functional-tests July 22, 2024 21:47 — with GitHub Actions Failure

sk593 changed the base branch from main to feature-bicep-compiler-merge July 22, 2024 21:47

sk593 changed the title ~~[wip] Update functional test workflow with test Bicep types~~ Update functional test workflow with test Bicep types Jul 22, 2024

sk593 force-pushed the update-func-test-workflow-bicep branch from a81d1aa to 4ecf627 Compare July 22, 2024 22:07

sk593 commented Jul 22, 2024

View reviewed changes

.github/workflows/functional-test-cloud.yaml Outdated Show resolved Hide resolved

sk593 commented Jul 22, 2024

View reviewed changes

hack/bicep-types-radius/generated/index.json Show resolved Hide resolved

sk593 marked this pull request as ready for review July 22, 2024 22:16

sk593 requested review from a team as code owners July 22, 2024 22:16

kachawla reviewed Jul 22, 2024

View reviewed changes

.github/workflows/functional-test-cloud.yaml Show resolved Hide resolved

kachawla reviewed Jul 22, 2024

View reviewed changes

kachawla approved these changes Jul 23, 2024

View reviewed changes

ytimocin requested changes Jul 23, 2024

View reviewed changes

.github/workflows/functional-test-noncloud.yaml Outdated Show resolved Hide resolved

sk593 commented Jul 23, 2024

View reviewed changes

sk593 force-pushed the update-func-test-workflow-bicep branch 2 times, most recently from 7cd37c4 to e8f3f99 Compare July 23, 2024 22:18

ytimocin reviewed Jul 24, 2024

View reviewed changes

sk593 commented Jul 30, 2024

View reviewed changes

sk593 mentioned this pull request Aug 1, 2024

Bicep compiler merge #7662

Merged

7 tasks

sk593 force-pushed the feature-bicep-compiler-merge branch from 6aeb77a to dbde31d Compare August 1, 2024 17:38

sk593 force-pushed the update-func-test-workflow-bicep branch from 60caa38 to a1d8ffd Compare August 1, 2024 17:38

sk593 added 8 commits August 1, 2024 10:38

update func test workflow

242dc6e

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update bicep types

b7f06b7

Signed-off-by: sk593 <shruthikumar@microsoft.com>

nit test folder location

9ceee49

Signed-off-by: sk593 <shruthikumar@microsoft.com>

nit

e831b94

Signed-off-by: sk593 <shruthikumar@microsoft.com>

move noncloud publishing to test step

5488384

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update docs

89f7239

Signed-off-by: sk593 <shruthikumar@microsoft.com>

update tests

03634c7

Signed-off-by: sk593 <shruthikumar@microsoft.com>

fix validate bicep workflow

a1d8ffd

Signed-off-by: sk593 <shruthikumar@microsoft.com>

lakshmimsft reviewed Aug 1, 2024

View reviewed changes

lakshmimsft approved these changes Aug 1, 2024

View reviewed changes

willdavsmith approved these changes Aug 1, 2024

View reviewed changes

lakshmimsft reviewed Aug 2, 2024

View reviewed changes

ytimocin reviewed Aug 2, 2024

View reviewed changes

ytimocin approved these changes Aug 2, 2024

View reviewed changes

sk593 merged commit 06d334a into feature-bicep-compiler-merge Aug 2, 2024
2 checks passed

sk593 deleted the update-func-test-workflow-bicep branch August 2, 2024 18:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update functional test workflow with test Bicep types #7730

Update functional test workflow with test Bicep types #7730

sk593 commented Jul 8, 2024

github-actions bot commented Jul 8, 2024 •

edited

Loading

codecov bot commented Jul 8, 2024 •

edited

Loading

sk593 Jul 22, 2024 •

edited

Loading

ytimocin Jul 24, 2024

sk593 Jul 24, 2024

kachawla Jul 22, 2024

sk593 Jul 23, 2024

kachawla Jul 23, 2024

sk593 Jul 23, 2024

sk593 Jul 23, 2024

ytimocin Jul 24, 2024

ytimocin left a comment

ytimocin Jul 24, 2024

sk593 Jul 24, 2024

ytimocin Jul 24, 2024

ytimocin Jul 24, 2024

sk593 Jul 24, 2024 •

edited

Loading

ytimocin Jul 24, 2024

sk593 commented Jul 24, 2024

sk593 Jul 30, 2024

lakshmimsft Aug 1, 2024 •

edited

Loading

sk593 Aug 1, 2024

lakshmimsft Aug 2, 2024

sk593 Aug 2, 2024

ytimocin Aug 2, 2024

sk593 Aug 2, 2024

Update functional test workflow with test Bicep types #7730

Update functional test workflow with test Bicep types #7730

Conversation

sk593 commented Jul 8, 2024

Description

Type of change

github-actions bot commented Jul 8, 2024 • edited Loading

Unit Tests

codecov bot commented Jul 8, 2024 • edited Loading

Codecov Report

sk593 Jul 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ytimocin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sk593 Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sk593 commented Jul 24, 2024

Choose a reason for hiding this comment

lakshmimsft Aug 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 8, 2024 •

edited

Loading

codecov bot commented Jul 8, 2024 •

edited

Loading

sk593 Jul 22, 2024 •

edited

Loading

sk593 Jul 24, 2024 •

edited

Loading

lakshmimsft Aug 1, 2024 •

edited

Loading