Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7561 - adding side effect import of kubernetes auth plugins. #7562

Merged
merged 1 commit into from
May 1, 2024

Conversation

superbeeny
Copy link
Contributor

Description

Adding 1 line to import the kubernetes auth plugins in the rad cli.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #7561

@superbeeny superbeeny requested review from a team as code owners May 1, 2024 15:55
…uth plugins.

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
@superbeeny superbeeny force-pushed the superbeeny/fix7561 branch from 517ba9f to fc8e787 Compare May 1, 2024 15:59
@rynowak
Copy link
Contributor

rynowak commented May 1, 2024

Thanks @superbeeny - were you able to confirm that this fixes your issue? Should be possible to test a local build with go run cmd/rad/main.go init.

@superbeeny
Copy link
Contributor Author

Yes, I built the binary to confirm as well

➜  radius git:(superbeeny/fix7561) sudo cp ./dist/darwin_arm64/release/rad /usr/local/bin/rad-edge
Password:
➜  radius git:(superbeeny/fix7561) rad-edge version
RELEASE   VERSION   BICEP     COMMIT
edge      517ba9f   0.33.0    517ba9fd64f69130f83e5f78943871c173f3fa68
➜  radius git:(superbeeny/fix7561) rad init
Unable to verify Radius installation. Cause: Kubernetes cluster unreachable: no Auth Provider found for name "oidc".

➜  radius git:(superbeeny/fix7561) rad-edge init

Select an existing environment or create a new one
  >  1. dev

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (45329a3) to head (fc8e787).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7562   +/-   ##
=======================================
  Coverage   63.59%   63.59%           
=======================================
  Files         414      414           
  Lines       23309    23309           
=======================================
  Hits        14823    14823           
  Misses       7224     7224           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superbeeny superbeeny temporarily deployed to functional-tests May 1, 2024 16:10 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented May 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository superbeeny/radius
Commit ref fc8e787
Unique ID funcd440d1c1f7
Image tag pr-funcd440d1c1f7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd440d1c1f7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd440d1c1f7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd440d1c1f7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd440d1c1f7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@rynowak
Copy link
Contributor

rynowak commented May 1, 2024

Yes, I built the binary to confirm as well

➜  radius git:(superbeeny/fix7561) sudo cp ./dist/darwin_arm64/release/rad /usr/local/bin/rad-edge
Password:
➜  radius git:(superbeeny/fix7561) rad-edge version
RELEASE   VERSION   BICEP     COMMIT
edge      517ba9f   0.33.0    517ba9fd64f69130f83e5f78943871c173f3fa68
➜  radius git:(superbeeny/fix7561) rad init
Unable to verify Radius installation. Cause: Kubernetes cluster unreachable: no Auth Provider found for name "oidc".

➜  radius git:(superbeeny/fix7561) rad-edge init

Select an existing environment or create a new one
  >  1. dev

Awesome, thanks!

@kachawla kachawla merged commit df0551d into radius-project:main May 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to rad init with v0.33.0
3 participants