Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AppGraph connection for direct route #7063
Support AppGraph connection for direct route #7063
Changes from 1 commit
590e100
147fae9
a3370d0
42ffbc7
becaecc
985110f
7beb51d
f601cb5
7e45ef1
4dbcefc
f43ef05
82a3b5f
431c5a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that input resource can be version-specific. Ideally, the appgraph's response needs to be version agnostic datamodel. @nithyatsu is there any reason why we use the version-specific response here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the app graph API would follow the same versioning principles we have for other APIs 👍
I think we just didn't think about versioning since it was the first one, but the idea makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this assume that the resource being connected to is in the same scope? So if I use multiple resource groups this will fall a part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what if I have a connection to something outside of Radius? eg:
http://example.com
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that we would support only
<scheme>://<resourcename>
format for connection, so the parser is designed for the case. To support the external endpoint, I would modify the connection format like below:instead of having
id
, we can havetarget
andtype
(or something else) to define connection. Puttingurl
onid
field doesn't seem right.cc/ @nithyatsu @rynowak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design doc for the features that connections support are here: #6375 @nithyatsu is the best resource for what parts of this have been implemented so far.
I don't think we discussed yet how an "external" URL should be represented in the app graph API, so I'm open to suggestions.
I want to make sure that we can represent a connection from
container a -> container b
and translate from URL -> resource ID in the app graph. The design for service-discovery was chosen to a support this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the bug. The following direction must be
OutBound
.radius/pkg/corerp/frontend/controller/applications/graph_util.go
Line 496 in fc4594e
@nithyatsu @rynowak Please review the new testdata to see if each resource connection has the right direction.