Add event logging for Terraform recipe publishing #7028
Conversation
sk593
force-pushed
the
tf-recipe-events
branch
from
9b14db2
to
b3b6593
Compare
sk593
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| with: | ||
| name: recipes-pod-logs | ||
| path: recipes/pod-logs | ||
| retention-days: 30 |
There was a problem hiding this comment.
What is the default value for retention? Wondering if we should this explicitly for other artifacts as well.
There was a problem hiding this comment.
Thanks Aaron. Not sure why the artifacts are expiring sooner than 90 days, for example they are showing as expired on this week old run https://github.com/radius-project/radius/actions/runs/7484284145
@sk593 I think 30 days is the right limit for tf recipe pod logs given that we don't use them often. We can review other artifacts separately.
There was a problem hiding this comment.
@sk593 I think 30 days is the right limit for tf recipe pod logs given that we don't use them often. We can review other artifacts separately.
Agreed, I don't think 90 days is necessary since this is just for the recipe uploads
There was a problem hiding this comment.
Maybe runs have different expiration days and the logs get archived somewhere else? Just thinking out loud... 🤣
There was a problem hiding this comment.
Ah just realized the repo had a retention period (7 days) which was overriding the org-level setting of 90 days. Just updated the repo to 90 days. We can remove this step-level retention period.
There was a problem hiding this comment.
Oh I see, updated to remove the retention value
There was a problem hiding this comment.
Ah thanks @AaronCrawfis, good to know, the increased duration will be helpful for investigations. Question unrelated to this PR - Do we have the ability to keep eye on the storage limits? If in case we start hitting them due to this increased retention and need to lower it below 90 days.
| with: | ||
| name: recipes-pod-logs | ||
| path: recipes/pod-logs | ||
| retention-days: 30 |
There was a problem hiding this comment.
Maybe runs have different expiration days and the logs get archived somewhere else? Just thinking out loud... 🤣
sk593
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593
force-pushed
the
tf-recipe-events
branch
from
a5b7d81
to
eef3ab3
Compare
sk593
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
# Description Adding logs to track pod failures during scheduled functional test runs ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius radius-project#6563 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6563 Signed-off-by: sk593 <shruthikumar@microsoft.com>
# Description Adding logs to track pod failures during scheduled functional test runs ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius radius-project#6563 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6563 Signed-off-by: sk593 <shruthikumar@microsoft.com>
Description
Adding logs to track pod failures during scheduled functional test runs
Type of change
Fixes: #6563