Add edge rad CLI install #6899

willdavsmith · 2023-12-01T20:58:53Z

Description

Updated install.sh to support edge as a valid argument and install using oras CLI if available
Updated install.ps1 to support edge as a valid argument and install using oras CLI if available
Removing isReleaseAvailable (unused)

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Auto-generated summary

`🤖[deprecated] Generated by Copilot at 62a66c5`

Summary

📦🚀🌐

Add support for installing edge version of radius CLI. Update deploy/install.sh to use oras or curl/wget depending on the version.

Sing, O Muse, of the skillful radius CLI
That lets the heroes deploy their code with ease
And how its install script was wisely enhanced
To offer two choices of version in advance

Walkthrough

Modify downloadFile function to accept RELEASE_TAG parameter and download either stable or edge version of Radius CLI (link, link)
Delete isReleaseAvailable function as it is obsolete (link)
Update getLatestReleaseTag function to return "edge" when passed as argument (link)

willdavsmith · 2023-12-01T21:01:57Z

deploy/install.sh

@@ -133,28 +147,6 @@ downloadFile() {
    fi
 }

-isReleaseAvailable() {


@sk593 do you know if we needed this somewhere? looks unused to me

deploy/install.sh

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

deploy/install.ps1

radius-functional-tests · 2023-12-04T22:36:07Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`bb422d5`
Unique ID	5db02ae6be
Image tag	pr-5db02ae6be

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-5db02ae6be
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-5db02ae6be
controller test image location: ghcr.io/radius-project/dev/controller:pr-5db02ae6be
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-5db02ae6be
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded
✅ datastoresrp functional tests succeeded

deploy/install.ps1

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com> Signed-off-by: Will Smith <willdavsmith@gmail.com>

radius-functional-tests · 2023-12-04T23:21:05Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`a481248`
Unique ID	db08070595
Image tag	pr-db08070595

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-db08070595
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-db08070595
controller test image location: ghcr.io/radius-project/dev/controller:pr-db08070595
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-db08070595
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

sylvainsf · 2023-12-05T20:24:18Z

Looks great, ship it! 🚢

AaronCrawfis

PowerShell looks good to me

deploy/install.ps1

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com> Signed-off-by: Will Smith <willdavsmith@gmail.com>

radius-functional-tests · 2023-12-07T19:06:18Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`e2ecbc0`
Unique ID	a2c486d174
Image tag	pr-a2c486d174

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-a2c486d174
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-a2c486d174
controller test image location: ghcr.io/radius-project/dev/controller:pr-a2c486d174
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-a2c486d174
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

kachawla

@willdavsmith Can you please share more context on why this change is needed?

willdavsmith · 2023-12-08T21:49:59Z

@willdavsmith Can you please share more context on why this change is needed?

Today, anyone that needs an edge build of radius needs to go install it manually from GitHub actions:
https://edge.radapp.dev/installation/

This change will allow for them to use the install script instead -
wget -q "https://raw.githubusercontent.com/radius-project/radius/main/deploy/install.sh" -O - | /bin/bash -s edge

sylvainsf

Looks good to me, tested on windows 11 desktop.

radius-functional-tests · 2023-12-08T22:05:47Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`0fb3319`
Unique ID	c718dd6cd9
Image tag	pr-c718dd6cd9

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-c718dd6cd9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-c718dd6cd9
controller test image location: ghcr.io/radius-project/dev/controller:pr-c718dd6cd9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-c718dd6cd9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

willdavsmith requested review from a team as code owners December 1, 2023 20:58

willdavsmith force-pushed the willdavsmith/oras-install branch from 62a66c5 to da73708 Compare December 1, 2023 21:00

willdavsmith commented Dec 1, 2023

View reviewed changes

AaronCrawfis reviewed Dec 1, 2023

View reviewed changes

deploy/install.sh Outdated Show resolved Hide resolved

deploy/install.sh Outdated Show resolved Hide resolved

willdavsmith changed the title ~~Adding unix-like edge rad cli install~~ Add edge rad CLI install Dec 4, 2023

willdavsmith requested review from sylvainsf and AaronCrawfis December 4, 2023 22:17

willdavsmith force-pushed the willdavsmith/oras-install branch 2 times, most recently from bb422d5 to 537fcf4 Compare December 4, 2023 22:20

commit

d704b77

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

willdavsmith force-pushed the willdavsmith/oras-install branch from 537fcf4 to d704b77 Compare December 4, 2023 22:24

willdavsmith commented Dec 4, 2023

View reviewed changes

deploy/install.ps1 Show resolved Hide resolved

AaronCrawfis reviewed Dec 4, 2023

View reviewed changes

deploy/install.ps1 Outdated Show resolved Hide resolved

Update deploy/install.ps1

a481248

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com> Signed-off-by: Will Smith <willdavsmith@gmail.com>

willdavsmith temporarily deployed to functional-tests December 4, 2023 23:20 — with GitHub Actions Inactive

willdavsmith requested a review from AaronCrawfis December 4, 2023 23:44

AaronCrawfis previously approved these changes Dec 7, 2023

View reviewed changes

deploy/install.ps1 Outdated Show resolved Hide resolved

Merge branch 'main' into willdavsmith/oras-install

60540c7

willdavsmith dismissed AaronCrawfis’s stale review via e2ecbc0 December 7, 2023 19:03

Update deploy/install.ps1

e2ecbc0

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com> Signed-off-by: Will Smith <willdavsmith@gmail.com>

willdavsmith temporarily deployed to functional-tests December 7, 2023 19:05 — with GitHub Actions Inactive

Merge branch 'main' into willdavsmith/oras-install

ac4f4e9

kachawla reviewed Dec 8, 2023

View reviewed changes

lechnerc77 mentioned this pull request Dec 8, 2023

feat: add devcontainer feature for radcli #6930

Merged

willdavsmith requested a review from AaronCrawfis December 8, 2023 21:43

Merge branch 'main' into willdavsmith/oras-install

0fb3319

sylvainsf approved these changes Dec 8, 2023

View reviewed changes

willdavsmith temporarily deployed to functional-tests December 8, 2023 22:05 — with GitHub Actions Inactive

willdavsmith merged commit 03ae959 into radius-project:main Dec 8, 2023
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add edge rad CLI install #6899

Add edge rad CLI install #6899

willdavsmith commented Dec 1, 2023 •

edited

Loading

willdavsmith Dec 1, 2023

radius-functional-tests bot commented Dec 4, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 4, 2023 •

edited

Loading

sylvainsf commented Dec 5, 2023

AaronCrawfis left a comment

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

kachawla left a comment

willdavsmith commented Dec 8, 2023

sylvainsf left a comment

radius-functional-tests bot commented Dec 8, 2023 •

edited

Loading

Add edge rad CLI install #6899

Add edge rad CLI install #6899

Conversation

willdavsmith commented Dec 1, 2023 • edited Loading

Description

Type of change

Auto-generated summary

🤖[deprecated] Generated by Copilot at 62a66c5

Summary

Walkthrough

willdavsmith Dec 1, 2023

Choose a reason for hiding this comment

radius-functional-tests bot commented Dec 4, 2023 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Dec 4, 2023 • edited Loading

Radius functional test overview

Test Status

sylvainsf commented Dec 5, 2023

AaronCrawfis left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Dec 7, 2023 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

willdavsmith commented Dec 8, 2023

sylvainsf left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Dec 8, 2023 • edited Loading

Radius functional test overview

Test Status

willdavsmith commented Dec 1, 2023 •

edited

Loading

`🤖[deprecated] Generated by Copilot at 62a66c5`

radius-functional-tests bot commented Dec 4, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 4, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 8, 2023 •

edited

Loading