-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edge rad CLI install #6899
Add edge rad CLI install #6899
Conversation
62a66c5
to
da73708
Compare
@@ -133,28 +147,6 @@ downloadFile() { | |||
fi | |||
} | |||
|
|||
isReleaseAvailable() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sk593 do you know if we needed this somewhere? looks unused to me
bb422d5
to
537fcf4
Compare
537fcf4
to
d704b77
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com> Signed-off-by: Will Smith <willdavsmith@gmail.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Looks great, ship it! 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PowerShell looks good to me
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com> Signed-off-by: Will Smith <willdavsmith@gmail.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willdavsmith Can you please share more context on why this change is needed?
Today, anyone that needs an edge build of radius needs to go install it manually from GitHub actions: This change will allow for them to use the install script instead - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested on windows 11 desktop.
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
install.sh
to supportedge
as a valid argument and install using oras CLI if availableinstall.ps1
to supportedge
as a valid argument and install using oras CLI if availableType of change
Fixes: #issue_number
Auto-generated summary
🤖[deprecated] Generated by Copilot at 62a66c5
Summary
📦🚀🌐
Add support for installing edge version of
radius
CLI. Updatedeploy/install.sh
to useoras
orcurl
/wget
depending on the version.Walkthrough
downloadFile
function to acceptRELEASE_TAG
parameter and download either stable or edge version of Radius CLI (link, link)isReleaseAvailable
function as it is obsolete (link)getLatestReleaseTag
function to return "edge" when passed as argument (link)