Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new recipe test with azure storage resource #6293

Closed
Tracked by #12
youngbupark opened this issue Jul 25, 2023 · 2 comments
Closed
Tracked by #12

Create new recipe test with azure storage resource #6293

youngbupark opened this issue Jul 25, 2023 · 2 comments
Assignees

Comments

@youngbupark
Copy link

youngbupark commented Jul 25, 2023

Bug information

Test_MongoDB_Recipe_ContextParameter is testing the recipe creating CosmosDB resources. However, CosmosDB resource is not a good resource since it spends many minutes for creating and deleting.

It is better to replace Test_MongoDB_Recipe_ContextParameter with new test which uses Azure storage. Azure storage doesn't require lots of time to create and delete the resources.

AB#8803

AB#9498

AB#10943

@willtsai willtsai transferred this issue from radius-project/radius Sep 19, 2023
@AaronCrawfis AaronCrawfis transferred this issue from another repository Sep 19, 2023
@kachawla
Copy link
Contributor

We can use either Azure storage resource or MongoDB on Kubernetes, given that value-backed recipes and the extender resource are now supported with recipes.

To provide more context on why we initially chose CosmosDB: During the first phase of the end-to-end recipes implementation, the Mongo portable resource was the first and only resource implemented to support recipes at the time. Support for Kubernetes resources was only introduced later when we added output values support in the authored recipe. So the selection of CosmosDB was not arbitrary; it was the only feasible option at that time. The intention was to transition away from Azure resources wherever possible in favor of Kubernetes support once it was in place, but it ended up not getting prioritized.

kachawla added a commit that referenced this issue Jan 18, 2024
# Description

Removing the dependency on Azure CosmosDB for context parameter
functional test and replacing the existing skipped test by introducing a
test that doesn't deploy any resources, as our primary goal is to verify
the successful population of the context parameter.

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

Fixes:
#5418
#6293

---------

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
@kachawla kachawla self-assigned this Jan 18, 2024
@kachawla
Copy link
Contributor

kachawla commented Jan 18, 2024

Handled it in #7041. Since the main goal of Test_MongoDB_Recipe_ContextParameter is to verify that the context parameter is successfully populated, we don't need dependency on creating a resource for this test, added a new test that validates a few fields in the context parameter without actually provisioning any resources.

willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Jan 26, 2024
…t#7041)

# Description

Removing the dependency on Azure CosmosDB for context parameter
functional test and replacing the existing skipped test by introducing a
test that doesn't deploy any resources, as our primary goal is to verify
the successful population of the context parameter.

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

Fixes:
radius-project#5418
radius-project#6293

---------

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Mar 4, 2024
…t#7041)

# Description

Removing the dependency on Azure CosmosDB for context parameter
functional test and replacing the existing skipped test by introducing a
test that doesn't deploy any resources, as our primary goal is to verify
the successful population of the context parameter.

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

Fixes:
radius-project#5418
radius-project#6293

---------

Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants