Skip to content

Commit

Permalink
Functional test with cloud workflow logging update (#8008)
Browse files Browse the repository at this point in the history
# Description

This PR updates the logging statements for the functional tests with
cloud resources. The removed logging statement triggers a security
warning, and the information being logged is similar to what is logged
in the next line of the workflow.

## Type of change

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Fixes:
https://github.com/radius-project/radius/security/code-scanning/492

## Contributor checklist
Please verify that the PR meets the following requirements, where
applicable:

- [ ] An overview of proposed schema changes is included in a linked
GitHub issue.
- [ ] A design document PR is created in the [design-notes
repository](https://github.com/radius-project/design-notes/), if new
APIs are being introduced.
- [ ] If applicable, design document has been reviewed and approved by
Radius maintainers/approvers.
- [ ] A PR for the [samples
repository](https://github.com/radius-project/samples) is created, if
existing samples are affected by the changes in this PR.
- [ ] A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made.
- [ ] A PR for the [recipes
repository](https://github.com/radius-project/recipes) is created, if
existing recipes are affected by the changes in this PR.

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
  • Loading branch information
brooke-hamilton authored Oct 22, 2024
1 parent 0506657 commit 719cb51
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/functional-test-cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ jobs:
# https://github.com/radius-project/radius/issues/7782
if [[ "${{ github.event_name }}" == "workflow_run" ]]; then
echo "Triggered by workflow_run."
echo "Head Ref: ${{ github.head_ref }}"
echo "Ref: ${{ github.ref }}"
echo "Head Branch Name: ${{ github.event.workflow_run.head_branch }}"
echo "SHA Value: ${{ github.event.workflow_run.head_sha }}"
Expand Down

0 comments on commit 719cb51

Please sign in to comment.