Radius Upgrades with GitOps #99
Conversation
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
| **Cons**: | ||
| - Helm-specific, possibility of Helm breaking changes in the future | ||
| - Have to build and integrate new container, `preflight`, into the Radius Helm chart | ||
| - Code duplication between `preflight` container and `rad` CLI |
There was a problem hiding this comment.
Can you expand on this a bit more? Wouldn't the rad CLI just use help upgrade?
| spec: | ||
| containers: | ||
| - name: preflight | ||
| image: ghcr.io/radius-project/preflight:{{ .Chart.AppVersion }} |
There was a problem hiding this comment.
I feel like another image will bring other maintenance issues with it. Is this going to be installed with each rad init and/or rad install?
There was a problem hiding this comment.
One more image for air-gapped environments.
There was a problem hiding this comment.
There will have to be CLI changes to be able to set this image and tag.
There was a problem hiding this comment.
There needs to be a flag on rad install kubernetes to not install the preflight container
|
|
||
| **Implementation**: | ||
| - Create Job template with `helm.sh/hook: pre-install,pre-upgrade` | ||
| - Package existing `pkg/upgrade/preflight` code from `pkg/upgrade/preflight/registry.go` |
There was a problem hiding this comment.
This will need to have a main.go and Dockerfile. I feel like it may be over-engineering at this point of rad upgrade kubernetes and rad rollback kubernetes.
| - Simplest to implement and maintain, taps into Flux and ArgoCD resources and doesn't require large Radius Helm chart changes | ||
|
|
||
| **Cons**: | ||
| - Requires separate reconcilers for Flux vs ArgoCD |
There was a problem hiding this comment.
Can we at least have a Base reconciler for different GitOps implementations? Like base.go and then flux.go and argocd.go may have different functions based on the need.
|
|
||
| ## Open Questions | ||
|
|
||
| Q: Should we consider using the `rad` CLI directly in the `preflight` container? |
There was a problem hiding this comment.
Would this help with eliminating the duplicated code problem in option 1?
| ``` | ||
|
|
||
| **Pros**: | ||
| - Simplest to implement and maintain, taps into Flux and ArgoCD resources and doesn't require large Radius Helm chart changes |
There was a problem hiding this comment.
this seems more complex to implement
No description provided.