Skip to content

UDT connections support #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nithyatsu
Copy link
Contributor

@nithyatsu nithyatsu commented May 20, 2025

This document captures the requirements for a connection involving a UDT resource

@nithyatsu nithyatsu requested review from a team as code owners May 20, 2025 21:47

When there is a `connections` construct in a `Applications.Core/containers` resource definition with source set to a UDT resource's id,
1. The UDT should be visible as a dependency in the application graph.
2. All of the properties of the UDT that are of numeric or string type should be set as environment variable in the container. The environment variable key would be `CONNECTION_CONN_NAME_VARIABLE_NAME` and value would be the value of varoable.
Copy link
Contributor

@lakshmimsft lakshmimsft May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question for @kachawla , @zachcasper
(correct me if I'm mistaken) Currently for existing connections in Containers, we create environment variables for recipe outputs when their types are string/float/int.
We could continue with the same approach for Container->UDT connections.
(I'm bringing this up since I thought I saw an earlier version of Connections PR follow the same approach as existing and maybe there will need to be more work done to get ALL properties in schema to have env variables). So, I'm checking if that is a requirement. 

Copy link
Contributor Author

@nithyatsu nithyatsu May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on offine discussion and the use case for external service, we are deciding to propogate all properties than just recipe output. @zachcasper @lakshmimsft @kachawla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants