Feature specification for in-place upgrade of Radius #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
force-pushed
the
ytimocin/feature/upgrades
branch
6 times, most recently
from
61da8dc to
88314f8
Compare
sylvainsf
reviewed
Mar 11, 2025
kachawla
reviewed
Mar 11, 2025
| 2. **Fetch available chart versions**: Provide a list of known chart versions so the desired version that the users select is a valid one. | ||
| 3. **Dry-run** (when requested): Simulate the upgrade, logging steps without making changes. Also making sure that the upgrade will work. Helm has this feature available in the `helm upgrade` command: <https://helm.sh/docs/helm/helm_upgrade/>. | ||
| 4. **Snapshot**: Automatically back up current data (e.g., etcd, resources in the API server, or Postgres) before making changes. | ||
| 5. **Upgrade**: Apply necessary Helm changes (including timeouts, set args, etc.), optionally perform database migrations if needed. |
There was a problem hiding this comment.
how do we know when to perform database migrations? if we introduce a breaking change to one of our schemas, is there an automatic way to detect and upgrade? probably not
kachawla
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
kachawla
reviewed
Mar 11, 2025
kachawla
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
kachawla
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
kachawla
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
sylvainsf
reviewed
Mar 11, 2025
kachawla
reviewed
Mar 11, 2025
ytimocin
force-pushed
the
ytimocin/feature/upgrades
branch
3 times, most recently
from
d9143ab to
624a1ad
Compare
ytimocin
force-pushed
the
ytimocin/feature/upgrades
branch
from
624a1ad to
ed05ea2
Compare
willtsai
reviewed
May 14, 2025
|
|
||
| - **Downgrade Support:** | ||
| - Should we support downgrading to previous versions? If yes, what are the limitations? | ||
| - How should we handle cases where users attempt to downgrade to versions that don't support the upgrade feature itself? |
There was a problem hiding this comment.
I think it's reasonable to only allow downgrades up to the first version that supported upgrades
| 4. **Snapshot**: Automatically back up current data (e.g., etcd, resources in the API server, or Postgres) before making changes. | ||
| 5. **Upgrade**: Apply necessary Helm changes (including timeouts, set args, etc.), optionally perform database migrations if needed. | ||
| 6. **Rollback** (on failure): If something goes wrong, use the snapshot to restore the prior state. | ||
| 7. **Post-upgrade checks**: Validate that new control plane components are healthy and confirm the upgrade was successful. |
There was a problem hiding this comment.
We've gotten some feedback from community users that they might have to roll back the upgrade even after the post-upgrade checks have passed (perhaps their own tests fail in the upgraded version) -- is it possible to do a rollback on the snapshot even after the upgrade successfully completes?
Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
ytimocin/feature/upgrades
branch
3 times, most recently
from
432f53c to
82361ea
Compare
Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
ytimocin/feature/upgrades
branch
from
82361ea to
ee3c7fa
Compare
Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
ytimocin/feature/upgrades
branch
from
0da75a2 to
2f847c2
Compare
willtsai
approved these changes
Jun 3, 2025
willtsai
reviewed
Jun 6, 2025
| - Upgrading the Radius control plane using Helm directly. We can run `helm upgrade` on the Radius Helm installation but that is not going to put all the necessary pieces together for the control plane to work. Making this work is not in the scope of this work. | ||
| - Zero-downtime control plane upgrades. While we aim to minimize disruption, guaranteeing absolutely no downtime for control plane components is not a goal for this initial release. | ||
| - Automatic CLI upgrades. Users must manually update their local CLI version after upgrading the control plane. | ||
| - Direct GitOps workflow integration for version 1. While users who manage Radius through HelmReleases in their GitOps pipeline will be able to update Helm charts, the complete upgrade process (including preflight checks, locking, and health verification) requires the `rad upgrade kubernetes` command in this initial version. Future versions will provide better GitOps integration options. |
There was a problem hiding this comment.
per @willdavsmith this is in scope now
willtsai
reviewed
Jun 6, 2025
Comment on lines
+205
to
+207
| ### GitOps Workflow Integration | ||
|
|
||
| In future versions, we plan to enhance GitOps integration to support users who manage Radius through HelmReleases as part of their GitOps workflow. This will include developing a Kubernetes operator that watches for HelmRelease changes and automatically performs the necessary upgrade procedures including preflight checks, locking, and health verification. This integration will allow teams to manage Radius upgrades through their existing GitOps pipelines without requiring manual CLI commands. |
There was a problem hiding this comment.
this is in scope now, per @willdavsmith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.