Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor evaluate_unc and fix deprecation warning #167

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

FeGeyer
Copy link
Member

@FeGeyer FeGeyer commented Oct 23, 2023

No description provided.

@FeGeyer FeGeyer added the fix Fixes an issue or problem label Oct 23, 2023
@FeGeyer FeGeyer requested a review from Kevin2 October 23, 2023 09:26
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7eff0fb) 59.85% compared to head (0bf0b92) 59.80%.

Files Patch % Lines
radionets/evaluation/scripts/start_evaluation.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   59.85%   59.80%   -0.05%     
==========================================
  Files          33       33              
  Lines        3609     3612       +3     
==========================================
  Hits         2160     2160              
- Misses       1449     1452       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FeGeyer
Copy link
Member Author

FeGeyer commented Oct 23, 2023

Found a potential bug, going to draft mode for the time being

@FeGeyer FeGeyer marked this pull request as draft October 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes an issue or problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant