-
Notifications
You must be signed in to change notification settings - Fork 0
add support for pagination #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
4www
wants to merge
6
commits into
main
Choose a base branch
from
feat/browse-paginated-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4fa3a8c
add pagination: utils.getBrowsePageParams & channel.browseChannels
5d44bd3
Merge branch 'main' into feat/browse-paginated-data
4www d1511c1
Merge branch 'main' into feat/browse-paginated-data
oskarrough 3f23cbe
Merge branch 'main' into feat/browse-paginated-data
oskarrough 1e03eb5
Merge branch 'main' into feat/browse-paginated-data
oskarrough ec8ba6d
Merge branch 'main' into feat/browse-paginated-data
oskarrough File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
converts "web component" attributes, to supabase sdk query parameters: | ||
-> page="1" limit="1" | ||
-> from[0] to to[0] limit[0] | ||
*/ | ||
export const getBrowsePageParams = ({page, limit}) => { | ||
let from, to, limitResults; | ||
from = (page - 1) * limit | ||
to = from + limit - 1 | ||
limitResults = limit - 1 | ||
return { from, to, limitResults } | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have
readChannels(limit)
andbrowseChannels({page, limit}
.How putting them together in
readChannels({limit, page})
orreadChannels(limit, page)
?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sounds cool too, passing an object sounds nice to me.
Also I keep thinking about this function here https://github.com/radio4000/components/blob/main/src/components/r4-list.js#L125-L146 where it allows all models to use the same function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example what if we browse "tracks" in a radio channel, and want to order them by title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, these params (
page
,limit
) will all be also bound to the URL, I guess this won't be in the sdk thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's change
readChannels
then.There must be many smart abstractions we can do. I feel for now we can experiment in r4-app by writing
sdk.supabase.from()
queries directly? And once we know the patterns move them to the sdk.