-
Notifications
You must be signed in to change notification settings - Fork 7
Adds documentation #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grunt? Don't you mean Gulp?
|
@gavD With the exception of the odd Grunt reference, everything looks fine to me. In fact, this is outstanding work. There are a few assertions that should be left for @nateabele. E.g., are you using Again, great work. 👍 |
|
Fixed the refs to Grunt. I've also added a PR which increases coverage to 95% - see #44 . |
src/angular-model.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like copypasta from $revert(). $exists() checks whether an object exists in the API, based on whether it has an identity URL.
References?
Yup.
Looks pretty good as-is. Maybe 'model definition class' if you want to get specific? I made notes on the few issues I saw. Everything else looks 👍. |
|
@nateabele thanks for the feedback :-) I have fixed all the issues you raised except for the one where I document |
* New gulp task `gulp ngdocs` to generate documentation into build/docs * Add ngdoc-compliant documentation to source code * Add documentation to README.md * Add Markdown version docs in /docs directory
|
Merging this now. Also, Bower is lame and no one should use it anymore. All of its reasons for existing have been superseded by improvements in tools that are actually good. |
gulp ngdocsto generate documentation into build/docsTest script
gulp ngdocthen open a web server as per the instructions, I'm a bit confused as to why it seems to think the namespace usursometimes andur.modelother times.overview? gulp-ngdocs doesn't supportmodulecode@nameshould beScript for generating Markdown docs
This script is scrappy but it works for now
Next steps
Once this is merged, we should: