surf: Open Diff to custom construction #139
Conversation
Put the Diff type in lines with its associated types by opening it up to construction by crate consumers. The existing associated types have all their fields public. Open construction up by making the `Diff::insert_*` methods public and updating the Diff's stats manually. `Diff::stat` correctness is covered by existing tests.
|
It looks like the linter is overly pedantic on the code base about changes unrelated to this PR. |
Hmmm weird that it just showed up. |
It's also not showing up for me locally. Even more curious 🤔 |
Ah, the toolchain went to 1.72.0, I'll merge this and also push a fix for that |
Seems like it's a false positive so I've reported an issue here rust-lang/rust-clippy#11402 |
Put the Diff type in lines with its associated types by opening it up to construction by crate consumers. The existing associated types have all their fields public.
Open construction up by making the
Diff::insert_*methods public and updating the Diff's stats manually.Diff::statcorrectness is covered by existing tests.