Skip to content

Commit

Permalink
surf: Add a small explainer on binary detection in diffs
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
  • Loading branch information
sebastinez committed Sep 25, 2023
1 parent 80ac22a commit b346709
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions radicle-surf/src/repo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,16 @@ impl Repository {
}
}

/// Create a diff with the difference between two tree objects.
///
/// Defines some options and flags that are passed to git2.
///
/// Note:
/// libgit2 optimizes around not loading the content when there's no content
/// callbacks configured. Be aware that binaries aren't detected as
/// expected.
///
/// Reference: https://github.com/libgit2/libgit2/issues/6637
fn diff_commits(
&self,
path: Option<&Path>,
Expand Down

0 comments on commit b346709

Please sign in to comment.