Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs #3256

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

fix docs #3256

wants to merge 3 commits into from

Conversation

AymenFJA
Copy link
Contributor

This addresses to #3254

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AymenFJA AymenFJA changed the title fix docs #3254 fix docs Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.83%. Comparing base (35a55ad) to head (f290844).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3256   +/-   ##
=======================================
  Coverage   42.83%   42.83%           
=======================================
  Files          97       97           
  Lines       11246    11246           
=======================================
  Hits         4817     4817           
  Misses       6429     6429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -64,6 +64,9 @@
"\n",
"pd_init = {'resource' : 'tacc.frontera',\n",
" 'access_schema': 'ssh'\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line misses a comma, causing the NB to fail.

Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor change request

@mtitov
Copy link
Contributor

mtitov commented Nov 13, 2024

@andre-merzky @AymenFJA have a general proposal to rewrite this section/tutorial:

  1. our focus is a "local" submission - either from the login node or from the compute node (i.e., inside the batch job, using interactive job or batch script). Thus, we don't talk about access_schema parameters here at all, because it is set by default. We can give examples of how to get interactive job or write a batch script (while considering that the RP pilot description is not anyhow different for these examples), but we should make a note that user is required to refer to the corresponding platform's user guide to follow their instructions.
  2. "remote" submission, which is optional and only if platform supports it. If it is the case, then user need to have a corresponding configuration within the resource config for that platform, and the name for that set of config parameters (e.g., ssh, gsissh, etc.) should be used in the access_schema for PilotDescription.

Thus, this section is about submission within the platform, the second part is optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants