-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docs #3256
base: devel
Are you sure you want to change the base?
fix docs #3256
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3256 +/- ##
=======================================
Coverage 42.83% 42.83%
=======================================
Files 97 97
Lines 11246 11246
=======================================
Hits 4817 4817
Misses 6429 6429 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -64,6 +64,9 @@ | |||
"\n", | |||
"pd_init = {'resource' : 'tacc.frontera',\n", | |||
" 'access_schema': 'ssh'\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line misses a comma, causing the NB to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor change request
@andre-merzky @AymenFJA have a general proposal to rewrite this section/tutorial:
Thus, this section is about submission within the platform, the second part is optional |
This addresses to #3254