apply cb lock #3234
Merged
apply cb lock #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3234 +/- ##
==========================================
- Coverage 43.52% 43.51% -0.01%
==========================================
Files 96 96
Lines 10967 10968 +1
==========================================
Hits 4773 4773
- Misses 6194 6195 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AymenFJA
approved these changes
Oct 1, 2024
| @@ -252,17 +252,18 @@ def _update(self, pilot_dict): | |||
|
|
|||
| # invoke pilot specific callbacks | |||
| # FIXME: this iteration needs to be thread-locked! | |||
There was a problem hiding this comment.
I am assuming the line with self._cb_lock did fix the FIXME above it? If so then let's remove the FIXME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3227