Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure state setting #3226

Merged
merged 5 commits into from
Sep 19, 2024
Merged

ensure state setting #3226

merged 5 commits into from
Sep 19, 2024

Conversation

andre-merzky
Copy link
Member

This fixes #3223

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.48%. Comparing base (1260818) to head (57f265f).
Report is 6 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/task_manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3226      +/-   ##
==========================================
- Coverage   43.48%   43.48%   -0.01%     
==========================================
  Files          96       96              
  Lines       10967    10968       +1     
==========================================
  Hits         4769     4769              
- Misses       6198     6199       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AymenFJA AymenFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it fixed the behavior observed in the ticket related to this PR. Currently, the current final state of the tasks in tmgr.0000.json are:

                    "node_name": "localhost"
                }
            ],
            "state": "DONE",
            "stderr": "",
            "stderr_file": "/home/aymen/radical.pilot.sandbox/rp.session.tsp920server.aymen.019985.0001/pilot.0000/task.000008//task.000008.err",
            "stderr_file_short": "$RP_TASK_SANDBOX/task.000008.err",
            "stdout": "Thu Sep 19 03:33:11 PM UTC 2024\n",

@andre-merzky andre-merzky merged commit 05dc803 into devel Sep 19, 2024
28 checks passed
@andre-merzky andre-merzky deleted the fix/task_state_transition branch September 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing state transition?
2 participants