initial implementation of task priorities #3215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3215 +/- ##
==========================================
+ Coverage 43.51% 43.56% +0.05%
==========================================
Files 96 96
Lines 10968 10987 +19
==========================================
+ Hits 4773 4787 +14
- Misses 6195 6200 +5 ☔ View full report in Codecov by Sentry. |
| @@ -305,6 +306,12 @@ class TaskDescription(ru.TypedDict): | |||
| the tasks did not manage to produce the expected output files to | |||
| stage. Default False. | |||
|
|
|||
| priority: (int, optional): The priority of the task. Tasks with higher | |||
| priority will be scheduled first. The default priority is 0. | |||
| The task process will not be strictly enforced strictly - under | |||
There was a problem hiding this comment.
typo strictly enforced strictly
There was a problem hiding this comment.
@andre-merzky while fixing this, can you please also remove duplication of PARTITION in both _schema and _defaults
| if uid in self._waitpool[priority]: | ||
| task = self._waitpool[priority][uid] | ||
| to_cancel.append(task) | ||
| del self._waitpool[priority][uid] |
There was a problem hiding this comment.
should it be break (after del ..) to leave the "priority"-loop?
| @@ -892,61 +907,70 @@ def _schedule_incoming(self): | |||
|
|
|||
There was a problem hiding this comment.
self.slot_status("before schedule incoming [%d]" % len(to_schedule))
priority should be considered here - sum of lengths of pools per priority
No description provided.