Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option --ppn in MPIEXEC LM #3035

Merged
merged 18 commits into from
Oct 31, 2023
Merged

Option --ppn in MPIEXEC LM #3035

merged 18 commits into from
Oct 31, 2023

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Sep 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #3035 (9118318) into devel (6170236) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel    #3035      +/-   ##
==========================================
+ Coverage   43.98%   43.99%   +0.01%     
==========================================
  Files          96       96              
  Lines       10568    10570       +2     
==========================================
+ Hits         4648     4650       +2     
  Misses       5920     5920              
Files Coverage Δ
src/radical/pilot/agent/launch_method/mpiexec.py 88.57% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mturilli
Copy link
Contributor

mturilli commented Oct 4, 2023

@GKNB does this PR implements the behavior you expected?

@andre-merzky
Copy link
Member

@GKNB does this PR implements the behavior you expected?

ping?

@GKNB
Copy link

GKNB commented Oct 25, 2023

I think this branch is also consistent with the main devel branch now, and in the main devel branch I can see a --ppn flag is already added for each task and it runs successfully for the mini-app, so I think it works fine.

@mtitov
Copy link
Contributor Author

mtitov commented Oct 31, 2023

confirmed with the test run on Polaris

@mtitov mtitov enabled auto-merge October 31, 2023 16:28
Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@mtitov mtitov merged commit b3eed97 into devel Oct 31, 2023
30 checks passed
@mtitov mtitov deleted the fix/mpiexec_ppn branch October 31, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend PALS MPIEXEC LM with ppn option
4 participants