Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/service startup flag #3026

Merged
merged 20 commits into from
Sep 29, 2023
Merged

Feature/service startup flag #3026

merged 20 commits into from
Sep 29, 2023

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Aug 31, 2023

No description provided.

@mtitov mtitov linked an issue Aug 31, 2023 that may be closed by this pull request
@mtitov mtitov self-assigned this Aug 31, 2023
@mtitov
Copy link
Contributor Author

mtitov commented Aug 31, 2023

@dyokelson hi Dewi, can you please try this branch to test services startup

(1) Installation of the required branches within your virtual environment (uninstall previous radical tools first)

pip install git+https://github.com/radical-cybertools/radical.utils.git@devel_nodb_2
pip install git+https://github.com/radical-cybertools/radical.pilot.git@feature/service_startup_flag

(2) Service task description - when you've described service task, set the metadata attribute as following

service_task = rp.TaskDescription()
...
service_task.metadata = {
    'name': 'soma_00',  # in RP Registry its URL will be accessed with path: 
                        #   "service.soma_00.<idx>.url"
                        # where <idx> refers to the instance id
    'startup_file': <full_path>  # for now try with the full path outside of the pilot sandbox
}
...
pd = rp.PilotDescription()
...
pd.services = [service_task]

@dyokelson

This comment was marked as resolved.

@mtitov

This comment was marked as resolved.

@mtitov mtitov marked this pull request as ready for review September 7, 2023 22:18
@dyokelson

This comment was marked as resolved.

@dyokelson
Copy link
Contributor

Hi, I have been able to launch SOMA as a service on one node and LULESH as a task on another - and they have been able to connect and send/receive data. Next I will be trying with the tau performance data layer and with different resource allocations (multiple nodes/tasks etc).

@mtitov mtitov marked this pull request as draft September 13, 2023 20:42
@mtitov mtitov changed the base branch from devel_nodb_2 to devel September 27, 2023 16:27
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #3026 (57bfad7) into devel (7b1d9d9) will increase coverage by 0.34%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##            devel    #3026      +/-   ##
==========================================
+ Coverage   42.41%   42.76%   +0.34%     
==========================================
  Files          99       99              
  Lines       10824    10858      +34     
==========================================
+ Hits         4591     4643      +52     
+ Misses       6233     6215      -18     
Files Coverage Δ
src/radical/pilot/agent/agent_0.py 40.54% <50.00%> (-1.97%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtitov mtitov marked this pull request as ready for review September 29, 2023 16:54
@mturilli mturilli self-requested a review September 29, 2023 18:50
Copy link
Contributor

@mturilli mturilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mturilli mturilli merged commit 26bcdff into devel Sep 29, 2023
29 checks passed
@mturilli mturilli deleted the feature/service_startup_flag branch September 29, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup flag (service URL) for the SOMA service
4 participants